Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(function): add support for domain resource #1359

Merged
merged 19 commits into from Nov 22, 2022

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone marked this pull request as draft July 7, 2022 08:23
@remyleone remyleone marked this pull request as ready for review July 11, 2022 13:03
@remyleone remyleone added the function Serverless function issues, bugs and feature requests label Jul 29, 2022
docs/resources/function_domain.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1359 (767ab8c) into master (e9daec6) will increase coverage by 0.00%.
The diff coverage is 70.49%.

@@           Coverage Diff            @@
##           master    #1359    +/-   ##
========================================
  Coverage   69.19%   69.20%            
========================================
  Files         142      143     +1     
  Lines       22973    23095   +122     
========================================
+ Hits        15896    15982    +86     
- Misses       5675     5701    +26     
- Partials     1402     1412    +10     
Impacted Files Coverage Δ
scaleway/resource_function_domain.go 66.66% <66.66%> (ø)
scaleway/helpers_function.go 77.08% <100.00%> (+2.27%) ⬆️
scaleway/provider.go 72.20% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax merged commit 4f8a3aa into scaleway:master Nov 22, 2022
@Codelax Codelax linked an issue Nov 22, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
function Serverless function issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function Endpoints / Custom Domain
3 participants