Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis): change acl from list to set #1366

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jul 11, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #1366 (dd99ee0) into master (27b2a0c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
- Coverage   66.67%   66.65%   -0.02%     
==========================================
  Files         119      119              
  Lines       19196    19196              
==========================================
- Hits        12799    12796       -3     
- Misses       5291     5293       +2     
- Partials     1106     1107       +1     
Impacted Files Coverage Δ
scaleway/helpers_redis.go 88.18% <100.00%> (ø)
scaleway/resource_redis_cluster.go 76.34% <100.00%> (ø)
scaleway/retryable_transport.go 70.00% <0.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b2a0c...dd99ee0. Read the comment docs.

@remyleone remyleone merged commit 05b7d09 into scaleway:master Jul 12, 2022
@Codelax Codelax deleted the redis_acl_set branch July 12, 2022 13:10
@remyleone remyleone added the redis Managed Redis issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis Managed Redis issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants