Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): root_volume boot value read and update #1372

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jul 13, 2022

Fix #1303

@Codelax Codelax marked this pull request as ready for review July 13, 2022 12:55
@codecov-commenter
Copy link

Codecov Report

Merging #1372 (8e9b8ca) into master (f9f55ab) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8e9b8ca differs from pull request most recent head 2158c65. Consider uploading reports for the commit 2158c65 to get more accurate results

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   66.69%   66.68%   -0.02%     
==========================================
  Files         122      122              
  Lines       19501    19503       +2     
==========================================
- Hits        13007    13006       -1     
- Misses       5357     5359       +2     
- Partials     1137     1138       +1     
Impacted Files Coverage Δ
scaleway/resource_instance_server.go 72.91% <100.00%> (+0.06%) ⬆️
scaleway/retryable_transport.go 70.00% <0.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c4b99...2158c65. Read the comment docs.

@Codelax Codelax merged commit cbc451c into scaleway:master Jul 13, 2022
@Codelax Codelax deleted the instance_root_volume_boot branch July 13, 2022 13:06
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance root volume boot value is always false
3 participants