Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance-private-nic): add wait for MAC address #1403

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Aug 1, 2022

No description provided.

@Monitob Monitob force-pushed the fix-vpc-nightly-test-data-source-reservation branch from 3be3a11 to 3bf555c Compare August 1, 2022 14:06
@Monitob Monitob force-pushed the fix-vpc-nightly-test-data-source-reservation branch from 3bf555c to b170dda Compare August 1, 2022 14:25
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #1403 (0dfb9d3) into master (31a8477) will increase coverage by 0.00%.
The diff coverage is 72.72%.

@@           Coverage Diff           @@
##           master    #1403   +/-   ##
=======================================
  Coverage   66.34%   66.35%           
=======================================
  Files         125      125           
  Lines       19817    19839   +22     
=======================================
+ Hits        13148    13164   +16     
- Misses       5520     5524    +4     
- Partials     1149     1151    +2     
Impacted Files Coverage Δ
scaleway/resource_instance_server.go 73.14% <25.00%> (-0.24%) ⬇️
scaleway/helpers_instance.go 77.48% <83.33%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a8477...0dfb9d3. Read the comment docs.

@Monitob Monitob linked an issue Aug 1, 2022 that may be closed by this pull request
@Monitob Monitob self-assigned this Aug 1, 2022
@Vinzius Vinzius changed the title Feat(instance-private-nic): add wait for MAC address feat(instance-private-nic): add wait for MAC address Aug 1, 2022
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Aug 1, 2022
@remyleone remyleone merged commit 9c98d0c into scaleway:master Aug 1, 2022
@Monitob Monitob deleted the fix-vpc-nightly-test-data-source-reservation branch August 1, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance: Add wait MAC address creation on Private NIC
3 participants