Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam_policy): use TypeList for rules #1410

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

kindermoumoute
Copy link
Contributor

No description provided.

Copy link
Member

@Codelax Codelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #1410 (9f958d5) into master (1cdf057) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
+ Coverage   66.25%   66.34%   +0.08%     
==========================================
  Files         126      126              
  Lines       20002    19980      -22     
==========================================
+ Hits        13253    13256       +3     
+ Misses       5586     5562      -24     
+ Partials     1163     1162       -1     
Impacted Files Coverage Δ
scaleway/helpers_iam.go 0.00% <0.00%> (ø)
scaleway/resource_iam_policy.go 0.00% <0.00%> (ø)
scaleway/retryable_transport.go 80.00% <0.00%> (+10.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kindermoumoute kindermoumoute merged commit 0c9aad0 into master Aug 5, 2022
@kindermoumoute kindermoumoute deleted the typelist-policy-rules branch August 5, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants