Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): set image and root_volume.volume_id to exactly one of #1598

Merged
merged 2 commits into from Nov 16, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Nov 14, 2022

Many snippets are coming in a next documentation PR

@Codelax Codelax added bug instance Instance issues, bugs and feature requests labels Nov 14, 2022
@Codelax Codelax self-assigned this Nov 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1598 (b4a7d73) into master (53ac552) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
+ Coverage   67.80%   67.82%   +0.01%     
==========================================
  Files         139      139              
  Lines       22686    22687       +1     
==========================================
+ Hits        15383    15387       +4     
+ Misses       5978     5976       -2     
+ Partials     1325     1324       -1     
Impacted Files Coverage Δ
scaleway/resource_instance_server.go 73.34% <100.00%> (+0.03%) ⬆️
scaleway/retryable_transport.go 77.50% <0.00%> (+7.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax merged commit 324c8a7 into scaleway:master Nov 16, 2022
@Codelax Codelax deleted the instance_image_exactly_one branch November 16, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants