Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): refactor root_volume creation #1599

Merged
merged 3 commits into from Nov 16, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Nov 14, 2022

No description provided.

@Codelax Codelax added refactor instance Instance issues, bugs and feature requests labels Nov 14, 2022
@Codelax Codelax self-assigned this Nov 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1599 (41a293d) into master (5f49b8a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
- Coverage   68.62%   68.61%   -0.02%     
==========================================
  Files         139      139              
  Lines       22686    22685       -1     
==========================================
- Hits        15569    15565       -4     
- Misses       5748     5750       +2     
- Partials     1369     1370       +1     
Impacted Files Coverage Δ
scaleway/resource_instance_server.go 73.27% <100.00%> (-0.04%) ⬇️
scaleway/retryable_transport.go 70.00% <0.00%> (-7.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax merged commit 7ed31f4 into scaleway:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants