Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(container_domain): check 404 responses #1624

Merged
merged 2 commits into from Nov 22, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Nov 21, 2022

No description provided.

@Codelax Codelax added bug container Container issues, bugs and feature requests labels Nov 21, 2022
@Codelax Codelax self-assigned this Nov 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #1624 (c36c27e) into master (65a248a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
- Coverage   69.21%   69.19%   -0.02%     
==========================================
  Files         142      142              
  Lines       22967    22973       +6     
==========================================
  Hits        15896    15896              
- Misses       5669     5675       +6     
  Partials     1402     1402              
Impacted Files Coverage Δ
scaleway/resource_container_domain.go 69.07% <0.00%> (-4.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax merged commit e9daec6 into scaleway:master Nov 22, 2022
@Codelax Codelax deleted the fix/container-domain-404 branch November 22, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug container Container issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants