Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): remove beta flag and add missing attribute on documentation #1644

Merged

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Dec 5, 2022

No description provided.

@Monitob Monitob self-assigned this Dec 5, 2022
@Monitob Monitob added the iam IAM issues, bugs and feature requests label Dec 5, 2022
@Monitob Monitob changed the title fix(docs): remove beta flag on documentation fix(iam): remove beta flag and add missing attribute on documentation Dec 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1644 (5e22ec2) into master (5292d40) will increase coverage by 4.42%.
The diff coverage is 81.98%.

❗ Current head 5e22ec2 differs from pull request most recent head 56b36f9. Consider uploading reports for the commit 56b36f9 to get more accurate results

@@            Coverage Diff             @@
##           master    #1644      +/-   ##
==========================================
+ Coverage   69.20%   73.62%   +4.42%     
==========================================
  Files         143      143              
  Lines       23095    23238     +143     
==========================================
+ Hits        15982    17109    +1127     
+ Misses       5701     4632    -1069     
- Partials     1412     1497      +85     
Impacted Files Coverage Δ
scaleway/resource_baremetal_server.go 75.21% <73.75%> (+7.32%) ⬆️
scaleway/resource_account_project.go 83.78% <80.00%> (+83.78%) ⬆️
scaleway/provider.go 76.45% <84.61%> (+4.24%) ⬆️
scaleway/helpers_baremetal.go 81.00% <94.33%> (+5.60%) ⬆️
scaleway/helpers.go 72.85% <0.00%> (+1.75%) ⬆️
scaleway/validation.go 64.86% <0.00%> (+10.81%) ⬆️
scaleway/helpers_account.go 100.00% <0.00%> (+50.00%) ⬆️
scaleway/data_source_account_project.go 64.15% <0.00%> (+64.15%) ⬆️
scaleway/data_source_iam_ssh_key.go 65.38% <0.00%> (+65.38%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Monitob Monitob merged commit 78672f7 into scaleway:master Dec 6, 2022
@Monitob Monitob deleted the fix-remove-flag-beta-documentation-iam branch December 6, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iam IAM issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants