Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iam): enhance documentation and format test #1651

Merged
merged 3 commits into from Dec 6, 2022
Merged

fix(iam): enhance documentation and format test #1651

merged 3 commits into from Dec 6, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Dec 6, 2022

No description provided.

@Monitob Monitob self-assigned this Dec 6, 2022
@Monitob Monitob added the iam IAM issues, bugs and feature requests label Dec 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022 •
edited

Codecov Report

Merging #1651 (c2af01c) into master (5534b8d) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head c2af01c differs from pull request most recent head a7bfb4c. Consider uploading reports for the commit a7bfb4c to get more accurate results

@@            Coverage Diff             @@
##           master    #1651      +/-   ##
==========================================
- Coverage   73.62%   73.62%   -0.01%     
==========================================
  Files         143      143              
  Lines       23241    23240       -1     
==========================================
- Hits        17112    17111       -1     
  Misses       4632     4632              
  Partials     1497     1497
Impacted Files Coverage Δ
scaleway/data_source_iam_group.go 70.00% <ø> (-0.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Monitob and others added 2 commits December 6, 2022 11:52
@Monitob @kindermoumoute
Update docs/data-sources/iam_application.md
c2af01c 
Co-authored-by: Olivier Cano <kindermoumoute@users.noreply.github.com>
@Monitob @kindermoumoute
Update docs/data-sources/iam_group.md
a7bfb4c 
Co-authored-by: Olivier Cano <kindermoumoute@users.noreply.github.com>
kindermoumoute
kindermoumoute approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Monitob Monitob merged commit 34bde49 into scaleway:master Dec 6, 2022
@Monitob Monitob deleted the fix-data-source-iam branch December 6, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees

@Monitob Monitob

Labels
iam IAM issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Monitob @codecov-commenter @kindermoumoute