Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tem) : add ressource for validate tem domain #2423

Merged
merged 3 commits into from
Apr 12, 2024
Merged

feat(tem) : add ressource for validate tem domain #2423

merged 3 commits into from
Apr 12, 2024

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Feb 27, 2024

close #1733

@jremy42 jremy42 force-pushed the feat/add-validation-domain-ressource branch from 0259630 to 836ed77 Compare February 27, 2024 10:46
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.87500% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 75.39%. Comparing base (fe86049) to head (336fba8).
Report is 22 commits behind head on master.

Files Patch % Lines
internal/services/tem/domain_validation.go 80.95% 11 Missing and 5 partials ⚠️
internal/services/tem/helpers.go 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2423      +/-   ##
==========================================
+ Coverage   71.43%   75.39%   +3.95%     
==========================================
  Files         277      278       +1     
  Lines       35875    30716    -5159     
==========================================
- Hits        25628    23158    -2470     
+ Misses       8028     5336    -2692     
- Partials     2219     2222       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 force-pushed the feat/add-validation-domain-ressource branch 7 times, most recently from b541fa3 to 04cdcfb Compare February 27, 2024 14:40
@jremy42 jremy42 self-assigned this Feb 27, 2024
remyleone
remyleone reviewed Feb 27, 2024
View reviewed changes
scaleway/provider.go Outdated Show resolved Hide resolved
scaleway/testdata/tem-domain-validation-basic.cassette.yaml Outdated Show resolved Hide resolved
@jremy42 jremy42 force-pushed the feat/add-validation-domain-ressource branch from 04cdcfb to 1253450 Compare February 27, 2024 15:26
@jremy42 jremy42 mentioned this pull request Mar 4, 2024
Closed
remyleone
remyleone reviewed Mar 6, 2024
View reviewed changes
scaleway/sweeper_test.go Outdated Show resolved Hide resolved
@jremy42 jremy42 force-pushed the feat/add-validation-domain-ressource branch 4 times, most recently from 4721e47 to 4296f06 Compare March 13, 2024 13:30
@remyleone remyleone added enhancement tem Transactional Email issues, bugs and feature requests priority:high New features labels Apr 10, 2024
@jremy42 jremy42 force-pushed the feat/add-validation-domain-ressource branch 2 times, most recently from c40cf30 to fd2400d Compare April 10, 2024 13:31
@jremy42 jremy42 force-pushed the feat/add-validation-domain-ressource branch from 8bca8dc to 336fba8 Compare April 12, 2024 13:05
@remyleone remyleone added this pull request to the merge queue Apr 12, 2024
Merged via the queue into scaleway:master with commit c7b60a4 Apr 12, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@jremy42 jremy42

Labels
enhancement priority:high New features tem Transactional Email issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a TEM domain check resource
3 participants
@jremy42 @codecov-commenter @remyleone