Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate types to its own package #2453

Merged
merged 2 commits into from Mar 13, 2024

Conversation

remyleone
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 64.86486% with 364 lines in your changes are missing coverage. Please review.

Project coverage is 73.08%. Comparing base (4638e19) to head (15716f7).

Files Patch % Lines
internal/types/string.go 1.83% 107 Missing ⚠️
internal/types/map.go 0.00% 48 Missing ⚠️
internal/types/ip.go 0.00% 21 Missing ⚠️
internal/types/number.go 0.00% 20 Missing ⚠️
internal/types/time.go 0.00% 19 Missing ⚠️
internal/types/bool.go 0.00% 10 Missing ⚠️
scaleway/resource_object.go 67.85% 9 Missing ⚠️
scaleway/resource_job_definition.go 30.00% 7 Missing ⚠️
scaleway/resource_k8s_cluster.go 66.66% 7 Missing ⚠️
internal/types/scw.go 0.00% 5 Missing ⚠️
... and 54 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2453      +/-   ##
==========================================
- Coverage   73.50%   73.08%   -0.42%     
==========================================
  Files         234      241       +7     
  Lines       35491    35491              
==========================================
- Hits        26089    25940     -149     
- Misses       7147     7317     +170     
+ Partials     2255     2234      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Codelax
Codelax previously approved these changes Mar 13, 2024
Codelax
Codelax previously approved these changes Mar 13, 2024
@remyleone remyleone added this pull request to the merge queue Mar 13, 2024
Merged via the queue into scaleway:master with commit b3b0802 Mar 13, 2024
34 checks passed
@remyleone remyleone deleted the split_types branch March 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants