test(k8s): fix naming + pn error in nightly tests #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
force-pushed
the
k8s_test_fix_naming_and_others
branch
from
4dcc110
to
45cff66
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2511 +/- ##
==========================================
+ Coverage 71.43% 75.33% +3.89%
==========================================
Files 277 277
Lines 35875 30660 -5215
==========================================
- Hits 25628 23098 -2530
+ Misses 8028 5339 -2689
- Partials 2219 2223 +4 ☔ View full report in Codecov by Sentry. |
remyleone
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly tests randomly come across this error when deleting resources after a test :
Error: scaleway-sdk-go: precondition failed: resource is still in use, Private Network must be empty to be deletedThis might be due to the
delete_additional_resources = trueattribute found in most clusters in the tests, which makes the kapsule API delete the attached private network, when we should let Terraform delete all resources. Indeed Terraform guarantees that actions will be performed in the right order and will be properly waited for.