Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(object): acl: revert bucket acl to private on resource deletion #2513

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Mia-Cross
Copy link
Contributor

Closes #2480

@Mia-Cross Mia-Cross self-assigned this Apr 9, 2024
@remyleone remyleone added object Object storage issues, bugs and feature requests bug priority:high New features labels Apr 10, 2024
@Mia-Cross Mia-Cross force-pushed the object_bucket_acl_deletion branch 2 times, most recently from 119e1fc to 62a3231 Compare April 12, 2024 13:59
@Mia-Cross Mia-Cross changed the title fix(object): bucket acl deletion fix(object): acl: revert bucket acl to private on resource deletion Apr 12, 2024
@Mia-Cross Mia-Cross marked this pull request as ready for review April 12, 2024 14:44
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.39%. Comparing base (fe86049) to head (c9de3db).
Report is 24 commits behind head on master.

Files Patch % Lines
internal/services/object/bucket_acl.go 81.81% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
+ Coverage   71.43%   75.39%   +3.95%     
==========================================
  Files         277      278       +1     
  Lines       35875    30729    -5146     
==========================================
- Hits        25628    23167    -2461     
+ Misses       8028     5338    -2690     
- Partials     2219     2224       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Apr 16, 2024
Merged via the queue into scaleway:master with commit f40b991 Apr 16, 2024
38 checks passed
@Mia-Cross Mia-Cross deleted the object_bucket_acl_deletion branch April 17, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug object Object storage issues, bugs and feature requests priority:high New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a scaleway_object_bucket_acl to set to public and then removing it doesn't revert back to private
3 participants