Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ter): review luiza products #2587

Merged
merged 3 commits into from
Jun 10, 2024
Merged

docs(ter): review luiza products #2587

merged 3 commits into from
Jun 10, 2024

Conversation

ldecarvalho-doc
Copy link
Contributor

Made a couple of small changes to text and form for the docs of my products.

docs/resources/rdb_read_replica.md Outdated Show resolved Hide resolved
docs/resources/rdb_read_replica.md Show resolved Hide resolved
docs/resources/rdb_instance.md Show resolved Hide resolved
docs/resources/iam_policy.md Outdated Show resolved Hide resolved
docs/resources/iam_policy.md Outdated Show resolved Hide resolved
@Codelax
Copy link
Member

Codelax commented May 31, 2024

There are multiple lint errors. All are due to the unexpected indentation for list elements.

docs/data-sources/billing_invoices.md:39:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:40:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:41:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:42:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:43:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:44:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:45:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:46:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:47:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:48:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:49:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:50:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:51:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:52:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:53:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/data-sources/billing_invoices.md:54:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/iam_policy.md:110:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/iam_policy.md:111:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/iam_policy.md:115:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:179:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:180:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:181:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:205:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:206:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:207:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:209:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:210:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:211:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:212:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:213:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:215:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:216:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:217:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:218:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_instance.md:219:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:93:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:94:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:95:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:114:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:115:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:116:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:117:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:118:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:120:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:121:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:122:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:123:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:124:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/rdb_read_replica.md:125:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/redis_cluster.md:183:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/redis_cluster.md:184:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/redis_cluster.md:185:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/redis_cluster.md:189:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/redis_cluster.md:190:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/tem_domain.md:149:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/tem_domain.md:150:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/tem_domain.md:151:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/tem_domain.md:152:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]
docs/resources/tem_domain.md:153:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 2]

@remyleone
Copy link
Member

I can indeed reproduce the issue.
@ldecarvalho-doc could you install brew install markdownlint-cli2 and do a markdownlint-cli2 docs?
It will help you reproduce locally the issue that is happening in the CI

@ldecarvalho-doc
Copy link
Contributor Author

I can indeed reproduce the issue. @ldecarvalho-doc could you install brew install markdownlint-cli2 and do a markdownlint-cli2 docs? It will help you reproduce locally the issue that is happening in the CI

Hey, I finally found what was causing the issues and fixed them.
Thanks!
Seems like all checks passed, but it's telling me the branch is out-of-date with master, even though I rebased like 20min ago... should I do it again?

@Codelax Codelax added this pull request to the merge queue Jun 10, 2024
Merged via the queue into master with commit 1e2fb0e Jun 10, 2024
45 checks passed
@Codelax Codelax deleted the MTA-4629 branch June 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants