-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tem): add support for webhook #2673
base: master
Are you sure you want to change the base?
Conversation
850b78e
to
7517944
Compare
8a29f1a
to
e96ce3c
Compare
09701ab
to
30c0046
Compare
internal/services/tem/webhook.go
Outdated
Description: "SNS ARN", | ||
ValidateFunc: validation.StringLenBetween(3, 127), | ||
}, | ||
"organization_id": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using "organization_id": account.OrganizationIDSchema()
internal/services/tem/webhook.go
Outdated
Computed: true, | ||
Description: "The organization id", | ||
}, | ||
"id": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When is this Id updated? Why you put an id in the schema explicitely while it is not the case in other resources?
No description provided.