Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tem): add support for webhook #2673

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Jul 31, 2024

No description provided.

@jremy42 jremy42 force-pushed the feat/add-ressource-webhook branch from 850b78e to 7517944 Compare July 31, 2024 09:32
@jremy42 jremy42 force-pushed the feat/add-ressource-webhook branch from 8a29f1a to e96ce3c Compare July 31, 2024 10:19
@jremy42 jremy42 force-pushed the feat/add-ressource-webhook branch from 09701ab to 30c0046 Compare July 31, 2024 12:07
@jremy42 jremy42 marked this pull request as ready for review July 31, 2024 12:29
@jremy42 jremy42 requested a review from remyleone as a code owner July 31, 2024 12:29
@jremy42 jremy42 changed the title Feat/add ressource webhook feat/add ressource webhook Jul 31, 2024
@remyleone remyleone changed the title feat/add ressource webhook feat(tem): add support for webhook Jul 31, 2024
Description: "SNS ARN",
ValidateFunc: validation.StringLenBetween(3, 127),
},
"organization_id": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using "organization_id": account.OrganizationIDSchema()

Computed: true,
Description: "The organization id",
},
"id": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this Id updated? Why you put an id in the schema explicitely while it is not the case in other resources?

@github-actions github-actions bot added the tem Transactional Email issues, bugs and feature requests label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tem Transactional Email issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants