Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rdb): add support for database backup #783

Merged
merged 18 commits into from Jun 16, 2022

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone marked this pull request as draft February 16, 2021 09:28
@remyleone remyleone mentioned this pull request Feb 16, 2021
3 tasks
@remyleone remyleone linked an issue Feb 16, 2021 that may be closed by this pull request
3 tasks
@Codelax Codelax marked this pull request as ready for review June 15, 2022 12:34
scaleway/provider.go Show resolved Hide resolved
scaleway/resource_rdb_database_backup.go Outdated Show resolved Hide resolved
scaleway/resource_rdb_database_backup.go Outdated Show resolved Hide resolved
scaleway/resource_rdb_database_backup_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #783 (9331e15) into master (171aeb9) will decrease coverage by 0.11%.
The diff coverage is 62.54%.

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
- Coverage   70.28%   70.17%   -0.12%     
==========================================
  Files         105      107       +2     
  Lines       17249    17516     +267     
==========================================
+ Hits        12124    12292     +168     
- Misses       4084     4165      +81     
- Partials     1041     1059      +18     
Impacted Files Coverage Δ
scaleway/resource_rdb_instance.go 71.42% <ø> (ø)
scaleway/helpers.go 73.68% <18.75%> (-1.94%) ⬇️
scaleway/data_source_rdb_database_backup.go 63.79% <63.79%> (ø)
scaleway/resource_rdb_database_backup.go 64.11% <64.11%> (ø)
scaleway/helpers_rdb.go 81.87% <76.19%> (-0.80%) ⬇️
scaleway/provider.go 73.83% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171aeb9...9331e15. Read the comment docs.

@remyleone remyleone merged commit 4f65569 into scaleway:master Jun 16, 2022
@remyleone remyleone deleted the rdb_backup branch June 16, 2022 10:00
remyleone added a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
Co-authored-by: Jules Casteran <jcasteran@scaleway.com>
@remyleone remyleone added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for rdb resources
4 participants