Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rdb): add support for acl rules #784

Merged
merged 29 commits into from May 21, 2021
Merged

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone marked this pull request as draft February 16, 2021 10:37
@remyleone remyleone mentioned this pull request Feb 16, 2021
3 tasks
@remyleone remyleone linked an issue Feb 16, 2021 that may be closed by this pull request
3 tasks
@ArcRiiad
Copy link

ArcRiiad commented Mar 8, 2021

Hey @remyleone, any update about the release of this feature ? 😄

@remyleone
Copy link
Member Author

@ArcRiiad Still working on it :) Would you be willing to check out the branch on your side and test it to give me feedback? :)

@ArcRiiad
Copy link

ArcRiiad commented Mar 8, 2021

@ArcRiiad Still working on it :) Would you be willing to check out the branch on your side and test it to give me feedback? :)

Yea sure, I'll try to take a moment and give it a try 👍

@LucasBoisserie
Copy link
Contributor

Hello @remyleone, i test this resource today
Terraform plan works but the apply fails with a 404 error

Plan output:

resource "scaleway_rdb_acl" "postgres_static_acl" {
    id          = (known after apply)
    instance_id = "fr-par/rdb-id"
    region      = (known after apply)

    acl_rules {
        description = "Static"
        ip          = "8.8.8.8"
    }
    acl_rules {
        description = "Static"
        ip          = "1.1.1.1"
    }
}

Apply output:

scaleway_rdb_acl.postgres_static_acl: Creating...
Error: scaleway-sdk-go: http error 404 Not Found: not found

@jeansebastienh jeansebastienh mentioned this pull request May 4, 2021
@jeansebastienh jeansebastienh linked an issue May 4, 2021 that may be closed by this pull request
@remyleone remyleone marked this pull request as ready for review May 21, 2021 12:47
@remyleone remyleone merged commit 1ada358 into scaleway:master May 21, 2021
@remyleone remyleone deleted the rdb_acl branch May 21, 2021 14:13
@Monitob Monitob mentioned this pull request Dec 30, 2021
5 tasks
@remyleone remyleone linked an issue Dec 30, 2021 that may be closed by this pull request
5 tasks
@remyleone remyleone added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDB Allowed Ips add support for rdb resources add data source support for rdb
4 participants