Skip to content

Commit

Permalink
fix(Link): new size (#3819)
Browse files Browse the repository at this point in the history
* fix: new link size

* fix: add changeset
  • Loading branch information
lisalupi committed May 24, 2024
1 parent c2e14d3 commit 0c77ec7
Show file tree
Hide file tree
Showing 10 changed files with 146 additions and 11 deletions.
5 changes: 5 additions & 0 deletions .changeset/chatty-dolphins-laugh.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ultraviolet/ui": patch
---

`<Links />`: added a new size 'xsmall'
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,7 @@ exports[`Banner > renders correctly with a link 1`] = `
prominence="default"
rel="noopener noreferrer"
target="_blank"
variant="bodySmallStrong"
>
Link
<span
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ exports[`Breadcrumbs > renders correctly with default values 1`] = `
class="emotion-4 emotion-5"
data-variant="standalone"
href="/step1"
variant="bodyStrong"
>
Step 1
</a>
Expand All @@ -142,6 +143,7 @@ exports[`Breadcrumbs > renders correctly with default values 1`] = `
class="emotion-4 emotion-5"
data-variant="standalone"
href="/step1/step2"
variant="bodyStrong"
>
I'm a very long... long long step
</a>
Expand Down Expand Up @@ -472,6 +474,7 @@ exports[`Breadcrumbs > renders correctly with onClick 1`] = `
class="emotion-4 emotion-5"
data-variant="standalone"
href="/step1"
variant="bodyStrong"
>
Step 1
</a>
Expand All @@ -484,6 +487,7 @@ exports[`Breadcrumbs > renders correctly with onClick 1`] = `
class="emotion-4 emotion-5"
data-variant="standalone"
href="/step1/step2"
variant="bodyStrong"
>
I'm a very long... long long step
</a>
Expand Down Expand Up @@ -631,6 +635,7 @@ exports[`Breadcrumbs > renders correctly with selected item 1`] = `
class="emotion-4 emotion-5"
data-variant="standalone"
href="/step1"
variant="bodyStrong"
>
Step 1
</a>
Expand All @@ -644,6 +649,7 @@ exports[`Breadcrumbs > renders correctly with selected item 1`] = `
class="emotion-4 emotion-5"
data-variant="standalone"
href="/step1/step2"
variant="bodyStrong"
>
I'm a very long... long long step
</a>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,7 @@ exports[`EmptySpace > should work with learn more 1`] = `
class="emotion-15 emotion-16"
data-variant="standalone"
href="https://scaleway.com"
variant="bodyStrong"
>
Learn more
<svg
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1770,6 +1770,7 @@ exports[`GlobalAlert > renders correctly with link 1`] = `
data-variant="inline"
href="scaleway.com"
prominence="stronger"
variant="bodySmallStrong"
>
Global Alert
</a>
Expand Down
6 changes: 5 additions & 1 deletion packages/ui/src/components/Link/__stories__/Size.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ import type { ComponentProps } from 'react'
import { Link } from '..'
import { Stack } from '../../Stack'

const sizes: ComponentProps<typeof Link>['size'][] = ['large', 'small']
const sizes: ComponentProps<typeof Link>['size'][] = [
'large',
'small',
'xsmall',
]

export const Size = (props: ComponentProps<typeof Link>) =>
sizes.map(size => (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ exports[`Link > prominence > render prominence default 1`] = `
data-variant="standalone"
href="/"
prominence="default"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -187,6 +188,7 @@ exports[`Link > prominence > render prominence strong 1`] = `
data-variant="standalone"
href="/"
prominence="strong"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -284,6 +286,7 @@ exports[`Link > prominence > render prominence stronger 1`] = `
data-variant="standalone"
href="/"
prominence="stronger"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -381,6 +384,7 @@ exports[`Link > prominence > render prominence weak 1`] = `
data-variant="standalone"
href="/"
prominence="weak"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -477,6 +481,7 @@ exports[`Link > render correctly with bad sentiment 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -573,6 +578,7 @@ exports[`Link > render correctly with href props 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -785,6 +791,7 @@ exports[`Link > render correctly with href props 2`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
<svg
class="emotion-2 emotion-3 emotion-4"
Expand All @@ -803,6 +810,7 @@ exports[`Link > render correctly with href props 2`] = `
class="emotion-5 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
<svg
Expand All @@ -823,6 +831,7 @@ exports[`Link > render correctly with href props 2`] = `
href="/"
rel="noopener noreferrer"
target="_blank"
variant="bodyStrong"
>
Hello
<span
Expand Down Expand Up @@ -852,6 +861,7 @@ exports[`Link > render correctly with href props 2`] = `
href="/"
rel="noopener noreferrer"
target="_blank"
variant="bodyStrong"
>
Hello
<span
Expand Down Expand Up @@ -968,6 +978,7 @@ exports[`Link > render correctly with no sentiment 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -1068,6 +1079,7 @@ exports[`Link > render correctly with oneLine 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello this is a very long text that should be truncated
</a>
Expand Down Expand Up @@ -1238,13 +1250,94 @@ exports[`Link > render correctly with sizes 1`] = `
text-decoration-thickness: 2px;
}
.emotion-4 {
background-color: transparent;
border: none;
padding: 0;
color: #005da3;
-webkit-text-decoration: underline;
text-decoration: underline;
text-decoration-thickness: 1px;
text-underline-offset: 2px;
text-decoration-color: transparent;
display: -webkit-inline-box;
display: -webkit-inline-flex;
display: -ms-inline-flexbox;
display: inline-flex;
-webkit-flex-direction: row;
-ms-flex-direction: row;
flex-direction: row;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
-webkit-transition: text-decoration-color 250ms ease-out;
transition: text-decoration-color 250ms ease-out;
gap: 8px;
position: relative;
cursor: pointer;
width: -webkit-fit-content;
width: -moz-fit-content;
width: fit-content;
font-size: 12px;
font-family: Inter,Asap,sans-serif;
font-weight: 500;
letter-spacing: 0;
line-height: 16px;
paragraph-spacing: 0;
text-case: none;
}
.emotion-4 .e1afnb7a2 {
-webkit-transition: -webkit-transform 250ms ease-out;
transition: transform 250ms ease-out;
}
.emotion-4>* {
pointer-events: none;
}
.emotion-4:hover,
.emotion-4:focus {
outline: none;
-webkit-text-decoration: underline;
text-decoration: underline;
text-decoration-thickness: 1px;
color: #004c85;
text-decoration-color: #004c85;
}
.emotion-4:hover .e1afnb7a2,
.emotion-4:focus .e1afnb7a2 {
-webkit-transform: translate(-4px, 0);
-moz-transform: translate(-4px, 0);
-ms-transform: translate(-4px, 0);
transform: translate(-4px, 0);
}
.emotion-4[data-variant='inline'] {
-webkit-text-decoration: underline;
text-decoration: underline;
text-decoration-thickness: 1px;
}
.emotion-4:hover::after,
.emotion-4:focus::after {
background-color: #005da3;
}
.emotion-4:active {
text-decoration-thickness: 2px;
}
<div
data-testid="testing"
>
<a
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand All @@ -1253,10 +1346,19 @@ exports[`Link > render correctly with sizes 1`] = `
class="emotion-2 emotion-1"
data-variant="standalone"
href="/"
variant="bodySmallStrong"
>
Hello
</a>
,
<a
class="emotion-4 emotion-1"
data-variant="standalone"
href="/"
variant="captionStrong"
>
Hello
</a>
</div>
</DocumentFragment>
`;
Expand Down Expand Up @@ -1374,6 +1476,7 @@ exports[`Link > render correctly with target blank 1`] = `
href="/"
rel="noopener noreferrer"
target="_blank"
variant="bodyStrong"
>
Hello
<span
Expand Down Expand Up @@ -1490,13 +1593,15 @@ exports[`Link > render correctly with variants props 1`] = `
class="emotion-0 emotion-1"
data-variant="inline"
href="/"
variant="bodyStrong"
>
Hello
</a>
<a
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -1593,6 +1698,7 @@ exports[`Link > sentiment > render danger 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -1689,6 +1795,7 @@ exports[`Link > sentiment > render info 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -1785,6 +1892,7 @@ exports[`Link > sentiment > render neutral 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -1881,6 +1989,7 @@ exports[`Link > sentiment > render primary 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -1977,6 +2086,7 @@ exports[`Link > sentiment > render secondary 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -2073,6 +2183,7 @@ exports[`Link > sentiment > render success 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down Expand Up @@ -2169,6 +2280,7 @@ exports[`Link > sentiment > render warning 1`] = `
class="emotion-0 emotion-1"
data-variant="standalone"
href="/"
variant="bodyStrong"
>
Hello
</a>
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/components/Link/__tests__/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ describe('Link', () => {
Hello
</Link>
,
<Link size="xsmall" href="/">
Hello
</Link>
</>,
))

Expand Down
Loading

0 comments on commit 0c77ec7

Please sign in to comment.