feat(Navigation): new pinned feature and reorder #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthprost
requested review from
DorianMaliszewski
and removed request for
a team
🦋 Changeset detectedLatest commit: e4d5e0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3717 +/- ##
=======================================
Coverage 89.58% 89.58%
=======================================
Files 190 190
Lines 4196 4196
Branches 629 629
=======================================
Hits 3759 3759
Misses 321 321
Partials 116 116 Continue to review full report in Codecov by Sentry.
|
PetmePant
previously requested changes
Apr 29, 2024
There was a problem hiding this comment.
- Issue with menu and active item while pinned. The pin item is not getting hidden when and overlaps with badge. (check video)
Screen.Recording.2024-04-29.at.10.33.20.AM.mov
- Alignment issue for the title/label of each pinned item and nav group header.
-
Pinned section should be always visible and with an empty state when no elements are pinned.
-
While reorder we should disable the initial nav item that is dragged
-
Drag & drop handler (cursor) should appear when you hover the drag icon/action and whole you drag and drop the cursor should be different.
-
When you pin an item you should have a toaster message
-
No items from the pinned section can be active similar to the rest of the items.
lisalupi
approved these changes
Apr 29, 2024
fabienhebert
approved these changes
Apr 30, 2024
packages/plus/src/components/Navigation/components/PinnedItems.tsx
Outdated
Show resolved
Hide resolved
packages/plus/src/components/Navigation/components/PinnedItems.tsx
Outdated
Show resolved
Hide resolved
packages/plus/src/components/Navigation/components/PinnedItems.tsx
Outdated
Show resolved
Hide resolved
matthprost
force-pushed
the
feat/nav-update-pin
branch
2 times, most recently
from
7c694cd
to
d6562cc
Compare
matthprost
force-pushed
the
feat/nav-update-pin
branch
from
860b75c
to
c8772b8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Introducing pin feature on Navigation ✨
Navigation is nice for traveling around in your website but it lacked some customization. Pinned feature is here to overcome this issue and provide a new way to customize your navigation. This feature can be enabled adding
pinnedFeatureon your<NavigationProvider />Pinned feature allows you to pin / unpin your favorite items until it reach the limit you've set using
pinLimiton your<NavigationProvider />.It also allows you to re-order your pinned items by using drag n drop and placing it in the order you like.
All your pinned items can be accessed with the hook
useNavigation():You can of course provide your initially pinned items to the
<NavigationProvider />by using the propinitialPinned.