-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SelectInputV2): autofocus searchbar #3727
Conversation
🦋 Changeset detectedLatest commit: 6e1735a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3727 +/- ##
=======================================
Coverage 89.60% 89.61%
=======================================
Files 190 190
Lines 4185 4189 +4
Branches 626 626
=======================================
+ Hits 3750 3754 +4
Misses 320 320
Partials 115 115
Continue to review full report in Codecov by Sentry.
|
Summary
Type
Summarise concisely:
What is expected?
Autofocusing the searchbar should not scroll to top. I add a temporary fix because @matthprost is working on
Popup
and will make a fix on this component. We will can put autoFocus back and drop my fix :)The following changes where made:
Use a ref for the Search bar input
Add an useEffect and setTimeout to focus it after Popup styles computation
Relevant logs and/or screenshots