fix(Navigation): some fixes

[matthprost]

Summary

Type

• Bug

Summarise concisely:

What is expected?

Fix <NavigationComponent /> to have correct empty state, pin / unpin to be div instead of button and fix on click on pin / unpin

[changeset-bot]

🦋 Changeset detected

Latest commit: ec024f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@ultraviolet/plus	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path

Size

packages/form/dist/constants.js, packages/form/dist/index.js, packages/themes/dist/index.js, packages/ui/dist/index.js, packages/form/dist/hooks/useField.js, packages/form/dist/hooks/useFieldArray.js, packages/form/dist/hooks/useForm.js, packages/form/dist/hooks/useFormState.js, packages/form/dist/hooks/useOnFieldChange.js, packages/form/dist/validators/maxDate.js, packages/form/dist/validators/minDate.js, packages/ui/dist/helpers/isJSON.js, packages/ui/dist/helpers/legend.js, packages/ui/dist/helpers/recursivelyGetChildrenString.js, packages/ui/dist/hooks/useIsOverflowing.js, packages/ui/dist/theme/index.js, packages/ui/dist/utils/animations.js, packages/ui/dist/utils/capitalize.js, packages/ui/dist/utils/ids.js, packages/ui/dist/utils/normalize.js, packages/form/dist/components/CheckboxField/index.js, packages/form/dist/components/CheckboxGroupField/index.js, packages/form/dist/components/DateField/index.js, packages/form/dist/components/Form/defaultErrors.js, packages/form/dist/components/Form/index.js, packages/form/dist/components/KeyValueField/index.js, packages/form/dist/components/NumberInputField/index.js, packages/form/dist/components/NumberInputFieldV2/index.js, packages/form/dist/components/RadioField/index.js, packages/form/dist/components/RadioGroupField/index.js, packages/form/dist/components/SelectInputField/index.js, packages/form/dist/components/SelectInputFieldV2/index.js, packages/form/dist/components/SelectableCardField/index.js, packages/form/dist/components/SelectableCardGroupField/index.js, packages/form/dist/components/Submit/index.js, packages/form/dist/components/SubmitErrorAlert/index.js, packages/form/dist/components/TagInputField/index.js, packages/form/dist/components/TextAreaField/index.js, packages/form/dist/components/TextInputField/index.js, packages/form/dist/components/TextInputFieldV2/index.js, packages/form/dist/components/TimeField/index.js, packages/form/dist/components/ToggleField/index.js, packages/form/dist/providers/ErrorContext/index.js, packages/themes/dist/themes/console/dark.js, packages/themes/dist/themes/console/darker.js, packages/themes/dist/themes/console/index.js, packages/themes/dist/themes/console/light.js, packages/ui/dist/components/ActionBar/index.js, packages/ui/dist/components/Alert/index.js, packages/ui/dist/components/Avatar/index.js, packages/ui/dist/components/Badge/index.js, packages/ui/dist/components/Banner/index.js, packages/ui/dist/components/BarChart/Tooltip.js, packages/ui/dist/components/BarChart/index.js, packages/ui/dist/components/BarStack/index.js, packages/ui/dist/components/Breadcrumbs/index.js, packages/ui/dist/components/Bullet/index.js, packages/ui/dist/components/Button/index.js, packages/ui/dist/components/Card/index.js, packages/ui/dist/components/Carousel/index.js, packages/ui/dist/components/Checkbox/index.js, packages/ui/dist/components/CheckboxGroup/index.js, packages/ui/dist/components/CopyButton/index.js, packages/ui/dist/components/DateInput/datepicker.css.js, packages/ui/dist/components/DateInput/index.js, packages/ui/dist/components/Dialog/Context.js, packages/ui/dist/components/Dialog/index.js, packages/ui/dist/components/EmptyState/index.js, packages/ui/dist/components/Expandable/index.js, packages/ui/dist/components/GlobalAlert/GlobalAlertLink.js, packages/ui/dist/components/GlobalAlert/index.js, packages/ui/dist/components/LineChart/CustomLegend.js, packages/ui/dist/components/LineChart/Tooltip.js, packages/ui/dist/components/LineChart/helpers.js, packages/ui/dist/components/LineChart/index.js, packages/ui/dist/components/Link/index.js, packages/ui/dist/components/List/Body.js, packages/ui/dist/components/List/Cell.js, packages/ui/dist/components/List/HeaderCell.js, packages/ui/dist/components/List/HeaderRow.js, packages/ui/dist/components/List/ListContext.js, packages/ui/dist/components/List/Row.js, packages/ui/dist/components/List/SelectBar.js, packages/ui/dist/components/List/SkeletonRows.js, packages/ui/dist/components/List/constants.js, packages/ui/dist/components/List/index.js, packages/ui/dist/components/Loader/index.js, packages/ui/dist/components/Menu/Item.js, packages/ui/dist/components/Menu/index.js, packages/ui/dist/components/MenuV2/Group.js, packages/ui/dist/components/MenuV2/Item.js, packages/ui/dist/components/MenuV2/index.js, packages/ui/dist/components/Meter/index.js, packages/ui/dist/components/Modal/Dialog.js, packages/ui/dist/components/Modal/Disclosure.js, packages/ui/dist/components/Modal/constants.js, packages/ui/dist/components/Modal/index.js, packages/ui/dist/components/Notice/index.js, packages/ui/dist/components/Notification/index.js, packages/ui/dist/components/Notification/react-toastify.css.js, packages/ui/dist/components/NumberInput/helpers.js, packages/ui/dist/components/NumberInput/index.js, packages/ui/dist/components/NumberInputV2/index.js, packages/ui/dist/components/Pagination/getPageNumbers.js, packages/ui/dist/components/Pagination/index.js, packages/ui/dist/components/PasswordCheck/index.js, packages/ui/dist/components/PasswordStrengthMeter/index.js, packages/ui/dist/components/PieChart/Legends.js, packages/ui/dist/components/PieChart/Tooltip.js, packages/ui/dist/components/PieChart/index.js, packages/ui/dist/components/Popover/index.js, packages/ui/dist/components/Popup/animations.js, packages/ui/dist/components/Popup/helpers.js, packages/ui/dist/components/Popup/index.js, packages/ui/dist/components/ProgressBar/index.js, packages/ui/dist/components/Radio/index.js, packages/ui/dist/components/RadioGroup/index.js, packages/ui/dist/components/Row/index.js, packages/ui/dist/components/SelectInput/index.js, packages/ui/dist/components/SelectInputV2/Dropdown.js, packages/ui/dist/components/SelectInputV2/DropdownOption.js, packages/ui/dist/components/SelectInputV2/SearchBarDropdown.js, packages/ui/dist/components/SelectInputV2/SelectBar.js, packages/ui/dist/components/SelectInputV2/SelectInputProvider.js, packages/ui/dist/components/SelectInputV2/findOptionInOptions.js, packages/ui/dist/components/SelectInputV2/index.js, packages/ui/dist/components/SelectInputV2/types.js, packages/ui/dist/components/SelectableCard/index.js, packages/ui/dist/components/SelectableCardGroup/index.js, packages/ui/dist/components/Separator/index.js, packages/ui/dist/components/Skeleton/Block.js, packages/ui/dist/components/Skeleton/Blocks.js, packages/ui/dist/components/Skeleton/BoxWithIcon.js, packages/ui/dist/components/Skeleton/Donut.js, packages/ui/dist/components/Skeleton/IconSkeleton.js, packages/ui/dist/components/Skeleton/Line.js, packages/ui/dist/components/Skeleton/List.js, packages/ui/dist/components/Skeleton/Slider.js, packages/ui/dist/components/Skeleton/Square.js, packages/ui/dist/components/Skeleton/index.js, packages/ui/dist/components/Snippet/index.js, packages/ui/dist/components/Stack/index.js, packages/ui/dist/components/Status/index.js, packages/ui/dist/components/StepList/index.js, packages/ui/dist/components/Stepper/index.js, packages/ui/dist/components/SwitchButton/FocusOverlay.js, packages/ui/dist/components/SwitchButton/index.js, packages/ui/dist/components/Table/Body.js, packages/ui/dist/components/Table/Cell.js, packages/ui/dist/components/Table/Header.js, packages/ui/dist/components/Table/HeaderCell.js, packages/ui/dist/components/Table/HeaderRow.js, packages/ui/dist/components/Table/Row.js, packages/ui/dist/components/Table/SelectBar.js, packages/ui/dist/components/Table/SkeletonRows.js, packages/ui/dist/components/Table/TableContext.js, packages/ui/dist/components/Table/index.js, packages/ui/dist/components/Tabs/Tab.js, packages/ui/dist/components/Tabs/TabMenu.js, packages/ui/dist/components/Tabs/TabMenuItem.js, packages/ui/dist/components/Tabs/TabsContext.js, packages/ui/dist/components/Tabs/index.js, packages/ui/dist/components/Tag/index.js, packages/ui/dist/components/TagInput/index.js, packages/ui/dist/components/TagList/index.js, packages/ui/dist/components/Text/index.js, packages/ui/dist/components/TextArea/index.js, packages/ui/dist/components/TextInput/index.js, packages/ui/dist/components/TextInputV2/index.js, packages/ui/dist/components/TimeInput/index.js, packages/ui/dist/components/Toaster/index.js, packages/ui/dist/components/Toaster/react-toastify.css.js, packages/ui/dist/components/Toggle/index.js, packages/ui/dist/components/ToggleGroup/index.js, packages/ui/dist/components/Tooltip/index.js, packages/ui/dist/components/VerificationCode/index.js, packages/ui/dist/utils/responsive/Breakpoint.js, packages/ui/dist/utils/responsive/utilities.js, packages/themes/dist/themes/console/deprecated/dark.js, packages/themes/dist/themes/console/deprecated/darker.js, packages/themes/dist/themes/console/deprecated/light.js, packages/ui/dist/components/Banner/assets/default-image-small.svg.js, packages/ui/dist/components/Banner/assets/default-image.svg.js, packages/ui/dist/components/Dialog/subComponents/Button.js, packages/ui/dist/components/Dialog/subComponents/Buttons.js, packages/ui/dist/components/Dialog/subComponents/CancelButton.js, packages/ui/dist/components/Dialog/subComponents/Stack.js, packages/ui/dist/components/Dialog/subComponents/Text.js

148.59 KB (0%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (362a534) to head (ec024f4).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3740   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files         190      190           
  Lines        4196     4196           
  Branches      629      629           
=======================================
  Hits         3759     3759           
  Misses        321      321           
  Partials      116      116           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362a534...ec024f4. Read the comment docs.

[philibea]

Missing some tests right ?