Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SelectInputV2): allow description as ReactNode and tooltip #3810

Merged
merged 3 commits into from
May 23, 2024

Conversation

DorianMaliszewski
Copy link
Member

@DorianMaliszewski DorianMaliszewski commented May 23, 2024

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

  • description of an option can be a ReactNode not just a string
  • tooltip can be added on an option

The following changes where made:

  1. Improve types
  2. Improve component
  3. Update snapshots

Copy link

changeset-bot bot commented May 23, 2024

🦋 Changeset detected

Latest commit: 720c176

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DorianMaliszewski DorianMaliszewski changed the title feat(SelectInputV2): allow description as ReactNode and tooltip for a… feat(SelectInputV2): allow description as ReactNode and tooltip May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.43%. Comparing base (6701696) to head (720c176).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3810      +/-   ##
==========================================
- Coverage   93.43%   93.43%   -0.01%     
==========================================
  Files         182      182              
  Lines        5832     5831       -1     
  Branches     2604     2641      +37     
==========================================
- Hits         5449     5448       -1     
  Misses        383      383              
Files Coverage Δ
...ui/src/components/SelectInputV2/DropdownOption.tsx 100.00% <100.00%> (ø)
...c/components/SelectInputV2/__tests__/resources.tsx 100.00% <ø> (ø)
packages/ui/src/components/SelectInputV2/types.ts 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6701696...720c176. Read the comment docs.

@DorianMaliszewski DorianMaliszewski merged commit 2c7da50 into main May 23, 2024
19 checks passed
@DorianMaliszewski DorianMaliszewski deleted the DS-847 branch May 23, 2024 09:58
@github-actions github-actions bot mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants