Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: card component flex issue - Ds 849 #3817

Merged
merged 11 commits into from
May 24, 2024
Merged

fix: card component flex issue - Ds 849 #3817

merged 11 commits into from
May 24, 2024

Conversation

Lawndlwd
Copy link
Member

Summary

Type

  • Bug

Summarise concisely:

What is expected?

the content of the box take half space of available space where it should take full space

The following changes where made:

remove flex from Card

Copy link

changeset-bot bot commented May 24, 2024

🦋 Changeset detected

Latest commit: 92d2608

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Lawndlwd Lawndlwd requested a review from lisalupi May 24, 2024 07:57
@Lawndlwd Lawndlwd self-assigned this May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (0c77ec7) to head (92d2608).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3817   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files         185      185           
  Lines        5921     5921           
  Branches     2671     2672    +1     
=======================================
  Hits         5537     5537           
  Misses        384      384           
Files Coverage Δ
packages/ui/src/components/Card/index.tsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c77ec7...92d2608. Read the comment docs.

@Lawndlwd Lawndlwd merged commit a915531 into main May 24, 2024
11 checks passed
@Lawndlwd Lawndlwd deleted the DS-849 branch May 24, 2024 14:21
@github-actions github-actions bot mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants