Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu alignment #3869

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: menu alignment #3869

merged 1 commit into from
Jun 12, 2024

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Bug

Summarise concisely:

What is expected?

MenuV2 : the text was centered instead of being on the left

Relevant logs and/or screenshots

Page Before After
url Capture d’écran 2024-06-12 à 14 56 22 Capture d’écran 2024-06-12 à 14 56 04

@lisalupi lisalupi requested review from matthprost and a team June 12, 2024 14:39
@lisalupi lisalupi self-assigned this Jun 12, 2024
@lisalupi lisalupi requested review from JulienSaguez and removed request for a team June 12, 2024 14:39
Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: 0a6f412

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (407888b) to head (0a6f412).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3869   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files         185      185           
  Lines        5921     5921           
  Branches     2632     2671   +39     
=======================================
  Hits         5536     5536           
  Misses        385      385           
Files Coverage Δ
packages/ui/src/components/MenuV2/Item.tsx 97.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407888b...0a6f412. Read the comment docs.

@lisalupi lisalupi merged commit 7dd5063 into main Jun 12, 2024
12 checks passed
@lisalupi lisalupi deleted the fix/menu-alignment branch June 12, 2024 15:40
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants