feat(NumberInputV2): controls prop #3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7f4e824 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lisalupi
force-pushed
the
feat/number-input-controls
branch
from
2693929
to
6676723
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3872 +/- ##
=======================================
Coverage 93.49% 93.50%
=======================================
Files 185 185
Lines 5922 5929 +7
Branches 2672 2678 +6
=======================================
+ Hits 5537 5544 +7
Misses 385 385
Continue to review full report in Codecov by Sentry.
|
matthprost
requested changes
Jun 14, 2024
packages/ui/src/components/NumberInputV2/__stories__/Controls.stories.tsx
Show resolved
Hide resolved
packages/plus/src/components/EstimateCost/__stories__/NumberInput.stories.tsx
Outdated
Show resolved
Hide resolved
lisalupi
force-pushed
the
feat/number-input-controls
branch
from
6676723
to
7f4e824
Compare
matthprost
approved these changes
Jun 17, 2024
BABAK0T0
approved these changes
Jun 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
<NumberInputV2 />: Added a new prop to hide controls<EstimateCost />The following changes were made:
<NumberInputV2 />: New propcontrols(defaulttrue. When set tofalse, the controls are hidden and the text is left-aligned)Added this prop to other component that uses
<NumberInputV2 />:<EstimateCost />&<NumberInputFieldV2 />Fix: stories description were not working for
<EstimateCost />Size limit for @ultraviolet/ui 500kB -> 550kB