fix(SelectInputV2): change data-testid place for easier unit tests #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9f26096 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthprost
approved these changes
Jun 14, 2024
DorianMaliszewski
force-pushed
the
fix/datatestid-selectinputV2
branch
from
0e8721c
to
8b4078b
Compare
lisalupi
approved these changes
Jun 14, 2024
DorianMaliszewski
force-pushed
the
fix/datatestid-selectinputV2
branch
from
8b4078b
to
72b9bf1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3876 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 185 185
Lines 5929 5930 +1
Branches 2679 2679
=======================================
+ Hits 5544 5545 +1
Misses 385 385
Continue to review full report in Codecov by Sentry.
|
DorianMaliszewski
force-pushed
the
fix/datatestid-selectinputV2
branch
from
1c8a747
to
9f26096
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
Place data-testid on the combobox instead of the wrapper to make testing easier
The following changes where made:
Change data-testid place from wrapper to combobox
Relevant logs and/or screenshots