Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new component search input #3885

Merged
merged 2 commits into from
Jun 18, 2024
Merged

feat: new component search input #3885

merged 2 commits into from
Jun 18, 2024

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Feature

Summarise concisely:

What is expected?

New component SearchInput that provides a text input with a popover shown under when you start typing.

Relevant logs and/or screenshots

Screenshot 2024-06-17 at 15 52 42

@matthprost matthprost added the enhancement New feature or request label Jun 17, 2024
@matthprost matthprost requested review from PetmePant, lisalupi, mhervouet and a team June 17, 2024 14:29
@matthprost matthprost self-assigned this Jun 17, 2024
@matthprost matthprost requested review from vincentaudebert and removed request for a team June 17, 2024 14:29
Copy link

changeset-bot bot commented Jun 17, 2024

🦋 Changeset detected

Latest commit: 97a7ebd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthprost matthprost requested a review from BABAK0T0 June 17, 2024 14:30
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.53%. Comparing base (10e7a83) to head (97a7ebd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3885      +/-   ##
==========================================
+ Coverage   93.50%   93.53%   +0.02%     
==========================================
  Files         185      186       +1     
  Lines        5929     5985      +56     
  Branches     2679     2698      +19     
==========================================
+ Hits         5544     5598      +54     
- Misses        385      387       +2     
Files Coverage Δ
packages/ui/src/components/SearchInput/index.tsx 96.42% <96.42%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e7a83...97a7ebd. Read the comment docs.

Copy link
Member

@BABAK0T0 BABAK0T0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice feature ! 👏🏽

@matthprost
Copy link
Collaborator Author

That's a nice feature ! 👏🏽

Thanks to you 😄

@matthprost matthprost merged commit 885c605 into main Jun 18, 2024
11 checks passed
@matthprost matthprost deleted the feat/search-component branch June 18, 2024 12:40
@scaleway-bot scaleway-bot mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants