Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some parenthesis #1101

Merged
merged 1 commit into from
Aug 3, 2020
Merged

remove some parenthesis #1101

merged 1 commit into from
Aug 3, 2020

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Aug 3, 2020

#1093 (comment)

Start 4.0 development - this major version can remove () from those method definitions

@xuwei-k xuwei-k requested a review from seratch August 3, 2020 03:51
seratch
seratch approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for working on these!

@seratch seratch merged commit 84e7ff9 into scalikejdbc:master Aug 3, 2020
@xuwei-k xuwei-k deleted the remove-parenthesis branch August 3, 2020 04:35
@seratch seratch added this to the version 4.0.x milestone Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
version 4.0.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xuwei-k @seratch