Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SQLSyntax.join() for retrieve delimiter's parameters #444

Merged
merged 1 commit into from Oct 1, 2015
Merged

Modify SQLSyntax.join() for retrieve delimiter's parameters #444

merged 1 commit into from Oct 1, 2015

Conversation

zaneli
Copy link
Contributor

@zaneli zaneli commented Oct 1, 2015

fix #443 degrade.

I guess including the parameters into delimiter is not a common use case,
but the fact remains that it's degrade.

  • after this modification
    val parts = (1 to 10000).map { id =>
      sqls"id=${id}"
    }
    val s = System.nanoTime()
    SQLSyntax.join(parts, sqls"and")
    println(System.nanoTime() - s)
436495000
416951000
414524000

:(

@seratch
Copy link
Member

seratch commented Oct 1, 2015

Thank you for fixing the latent bug 🙇

seratch added a commit that referenced this pull request Oct 1, 2015
…-parameters

Modify SQLSyntax.join() for retrieve delimiter's parameters
@seratch seratch merged commit 987ee88 into scalikejdbc:master Oct 1, 2015
@zaneli zaneli deleted the sqlsyntax-join-retrieve-delimiter-parameters branch October 1, 2015 05:44
@seratch seratch added the core label Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants