Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exhaustive warnings. change "sealed abstract class" and "case object" #649

Merged
merged 1 commit into from Mar 14, 2017

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Mar 14, 2017

before
https://travis-ci.org/scalikejdbc/scalikejdbc/jobs/210757869#L869

[warn] /home/travis/build/scalikejdbc/scalikejdbc/scalikejdbc-mapper-generator-core/src/main/scala/scalikejdbc/mapper/CodeGenerator.scala:327: match may not be exhaustive.
[warn] It would fail on the following input: GeneratorTemplate(_)
[warn]       val placeHolderPart: String = config.template match {
[warn]                                            ^
[warn] /home/travis/build/scalikejdbc/scalikejdbc/scalikejdbc-mapper-generator-core/src/main/scala/scalikejdbc/mapper/CodeGenerator.scala:347: match may not be exhaustive.
[warn] It would fail on the following input: GeneratorTemplate(_)
[warn]         (config.template match {
[warn]                 ^
[warn] /home/travis/build/scalikejdbc/scalikejdbc/scalikejdbc-mapper-generator-core/src/main/scala/scalikejdbc/mapper/CodeGenerator.scala:354: match may not be exhaustive.
[warn] It would fail on the following input: GeneratorTemplate(_)
[warn]         (config.template match {
[warn]                 ^
[warn] /home/travis/build/scalikejdbc/scalikejdbc/scalikejdbc-mapper-generator-core/src/main/scala/scalikejdbc/mapper/CodeGenerator.scala:361: match may not be exhaustive.
[warn] It would fail on the following input: GeneratorTemplate(_)
[warn]         (config.template match {
[warn]                 ^
[warn] /home/travis/build/scalikejdbc/scalikejdbc/scalikejdbc-mapper-generator-core/src/main/scala/scalikejdbc/mapper/CodeGenerator.scala:413: match may not be exhaustive.
[warn] It would fail on the following input: GeneratorTemplate(_)
[warn]       val placeHolderPart: String = config.template match {
[warn]                                            ^
[warn] /home/travis/build/scalikejdbc/scalikejdbc/scalikejdbc-mapper-generator-core/src/main/scala/scalikejdbc/mapper/CodeGenerator.scala:425: match may not be exhaustive.
[warn] It would fail on the following input: GeneratorTemplate(_)
[warn]       val wherePart = config.template match {
[warn]                              ^

@seratch seratch merged commit 2130fd5 into scalikejdbc:master Mar 14, 2017
@xuwei-k xuwei-k deleted the exhaustive-warning branch March 14, 2017 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants