use def instead of lazy val #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think there is no benefit following pattern
```
class A(val x)
class B(y: A) {
lazy val z = y.x
}
```
seratch
reviewed
Jul 23, 2017
| private[streams] lazy val statement: String = underlying.statement | ||
| private[streams] lazy val rawParameters: Seq[Any] = underlying.rawParameters | ||
| private[streams] lazy val parameters: Seq[Any] = underlying.parameters | ||
| private[streams] def statement: String = underlying.statement |
There was a problem hiding this comment.
Is there any specific reason to change only these three attributes (statement, rawParameters, and parameters)? What do you think changing extractor, fetchSize, tags, and queryTimeout as well?
There was a problem hiding this comment.
extractor, fetchSize, tags, and queryTimeout are not val
- https://github.com/scalikejdbc/scalikejdbc/blob/3.0.1/scalikejdbc-core/src/main/scala/scalikejdbc/SQL.scala#L155
- https://github.com/scalikejdbc/scalikejdbc/blob/3.0.1/scalikejdbc-core/src/main/scala/scalikejdbc/SQL.scala#L215
- https://github.com/scalikejdbc/scalikejdbc/blob/3.0.1/scalikejdbc-core/src/main/scala/scalikejdbc/SQL.scala#L208
- https://github.com/scalikejdbc/scalikejdbc/blob/3.0.1/scalikejdbc-core/src/main/scala/scalikejdbc/SQL.scala#L238
There was a problem hiding this comment.
hmm, I see. LGTM for these changes, so far.
|
LGTM. We need to fix the build issue with sbt 1.0, though. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is no benefit following pattern