Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(errors) harmonize caps #64

Merged
merged 1 commit into from
Mar 16, 2016
Merged

Conversation

koolfunky
Copy link

@koolfunky koolfunky force-pushed the dev/CLEANUP/refactorErrorCapitalLetter branch from 2bf25bb to 8fbbc36 Compare March 16, 2016 11:53
@adrienverge
Copy link
Contributor

Make all errors start with capital letter

Why? They're not classes?

@koolfunky
Copy link
Author

@adrienverge I guess you are right, it must not be like that but for now I think it is preferable to do it this way because for harmonize all the errors with lowercase first letter we need to refactor all the projects

@adrienverge
Copy link
Contributor

Fair enough 👍

@jmunoznaranjo
Copy link
Contributor

@adrienverge mixing caps and lower case error names was too error-prone. Actually this PR is motivated by a bugfix a couple of days ago ;)

👍

@adrienverge
Copy link
Contributor

mixing caps and lower case error names was too error-prone.

@jmunoznaranjo I agree with you. But I would prefer these errors objects to all start with lowercase (instead of all start with capital).

@MathieuCassagne
Copy link
Contributor

👍

@jmunoznaranjo
Copy link
Contributor

@adrienverge yeah, I understand your reasoning: caps should be restricted to classes.

I'm ok with both solutions as long as there is homogeneity.

 * Make all errors start with capital letter
 * fix #54
@koolfunky koolfunky force-pushed the dev/CLEANUP/refactorErrorCapitalLetter branch from 8fbbc36 to 45c9d5b Compare March 16, 2016 16:51
koolfunky pushed a commit that referenced this pull request Mar 16, 2016
@koolfunky koolfunky merged commit 201f39b into rel/1.0 Mar 16, 2016
@koolfunky koolfunky deleted the dev/CLEANUP/refactorErrorCapitalLetter branch March 16, 2016 17:23
@koolfunky koolfunky mentioned this pull request Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants