Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time progression factor to make 1day equal to 1s #1947

Merged
merged 13 commits into from
Sep 20, 2023
Merged

Add time progression factor to make 1day equal to 1s #1947

merged 13 commits into from
Sep 20, 2023

Conversation

KillianG
Copy link
Collaborator

@KillianG KillianG commented Aug 31, 2023 •
edited by francoisferrand
Loading

Issue: ZENKO-4630

@bert-e
Copy link
Contributor

bert-e commented Aug 31, 2023

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@KillianG KillianG force-pushed the improvement/ZENKO-4630-Add-test-for-expiration-of-restoration-of-objects-in-cold-location branch 8 times, most recently from 1072615 to 5dd97c0 Compare September 7, 2023 06:36
@scality scality deleted a comment from bert-e Sep 7, 2023
@bert-e
Copy link
Contributor

bert-e commented Sep 7, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

francoisferrand
francoisferrand reviewed Sep 7, 2023
View reviewed changes
.github/scripts/end2end/run-e2e-ctst.sh Outdated Show resolved Hide resolved
tests/ctst/features/azureArchive.feature Show resolved Hide resolved
tests/ctst/features/azureArchive.feature Outdated Show resolved Hide resolved
@KillianG KillianG force-pushed the improvement/ZENKO-4630-Add-test-for-expiration-of-restoration-of-objects-in-cold-location branch from 41cb4f5 to d5acf7a Compare September 8, 2023 09:59
@bert-e
Copy link
Contributor

bert-e commented Sep 8, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@KillianG KillianG force-pushed the improvement/ZENKO-4630-Add-test-for-expiration-of-restoration-of-objects-in-cold-location branch 2 times, most recently from c7577bf to c7a9e22 Compare September 8, 2023 14:16
KillianG and others added 5 commits September 14, 2023 17:30
@KillianG @francoisferrand
Initialize ZENKOANNOTATION to null string to avoi problem with set-u
6896b7a 
Issue: ZENKO-4630
@francoisferrand
Keep original capitalization for network params
3c2333f 
This capitalization is used in CTST, even though TS compiler does not
get the mismatch.

Issue: ZENKO-4630
@francoisferrand
Fix lint issues
e350e29 
Issue: ZENKO-4630
@francoisferrand
Recapitalize keycloak* params
6b6b231 
Issue: ZENKO-4630
@francoisferrand
Remove fallback from ZenkoWorldParameter
0ebdf3f 
ZenkoWorldParameters is expected to Zenko's custom world params, as
documented in [1]: so we should not add such a fallback, which prevents
TS compiler from verifying that we use only valid fields/params.

[1]: https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/world.md#typescript

Issue: ZENKO-4630
@francoisferrand francoisferrand force-pushed the improvement/ZENKO-4630-Add-test-for-expiration-of-restoration-of-objects-in-cold-location branch from dd547d2 to 81056ab Compare September 18, 2023 10:27
@francoisferrand francoisferrand force-pushed the improvement/ZENKO-4630-Add-test-for-expiration-of-restoration-of-objects-in-cold-location branch from 81056ab to edeb827 Compare September 18, 2023 11:42
@scality scality deleted a comment from bert-e Sep 18, 2023
@scality scality deleted a comment from bert-e Sep 18, 2023
@scality scality deleted a comment from bert-e Sep 18, 2023
francoisferrand
francoisferrand reviewed Sep 18, 2023
View reviewed changes
tests/ctst/world/Zenko.ts
@@ -156,8 +143,8 @@ export default class Zenko extends World<ZenkoWorldParameters> {
}

// Workaround to be able to access global parameters in BeforeAll/AfterAll hooks
CacheHelper.parameters = this.parameters;
this.cliMode.parameters = this.parameters as ClientOptions;
CacheHelper.parameters = this.parameters as unknown as Record<string, unknown>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is required until fixed in CTST (https://scality.atlassian.net/browse/CTST-34)

@francoisferrand
Copy link
Contributor

francoisferrand commented Sep 20, 2023 •
edited
Loading

/bypass_author_approval

@scality scality deleted a comment from bert-e Sep 20, 2023
@bert-e
Copy link
Contributor

bert-e commented Sep 20, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.8

The following branches will NOT be impacted:

  • development/2.5
  • development/2.6
  • development/2.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: bypass_author_approval

@scality scality deleted a comment from bert-e Sep 20, 2023
@bert-e
Copy link
Contributor

bert-e commented Sep 20, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.8

The following branches have NOT changed:

  • development/2.5
  • development/2.6
  • development/2.7

Please check the status of the associated issue ZENKO-4630.

Goodbye killiang.

@bert-e bert-e merged commit edeb827 into development/2.8 Sep 20, 2023
17 checks passed
@bert-e bert-e deleted the improvement/ZENKO-4630-Add-test-for-expiration-of-restoration-of-objects-in-cold-location branch September 20, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisferrand francoisferrand francoisferrand approved these changes

@Kerkesni Kerkesni Kerkesni approved these changes

@KazToozs KazToozs Awaiting requested review from KazToozs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KillianG @bert-e @francoisferrand @Kerkesni