-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listing Implementation Issue #147
Comments
As there is no "delimiter" parameter in the query string, I do not see what's wrong in the answer here. Is seems expected that we'd list Anyhow, Michael found a sample request on the amazon doc that does not seem to work with our implementation. He'll be fixing that first. |
Just to be sure, I'll take an example straight from the documentation:
The following GET request specifies the GET /?prefix=photos/2006/&delimiter=/ HTTP/1.1
Host: example-bucket.s3.amazonaws.com
Date: Wed, 01 Mar 2006 12:00:00 GMT
Authorization: authorization string In response, Amazon S3 returns only the keys that start with the specified prefix. Further, it uses the delimiter character to group keys that contain the same substring until the first occurrence of the delimiter character after the specified prefix. For each such key group Amazon S3 returns one <ListBucketResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
<Name>example-bucket</Name>
<Prefix>photos/2006/</Prefix>
<Marker></Marker>
<MaxKeys>1000</MaxKeys>
<Delimiter>/</Delimiter>
<IsTruncated>false</IsTruncated>
<CommonPrefixes>
<Prefix>photos/2006/February/</Prefix>
</CommonPrefixes>
<CommonPrefixes>
<Prefix>photos/2006/January/</Prefix>
</CommonPrefixes>
</ListBucketResult> It is not the case at the moment (at least when using the memory backend). |
Note that we observed that the S3 memory backend does not seem to make use On Tue, Aug 30, 2016 at 3:54 PM, Michael Zapata notifications@github.com
David Pineau |
There is a preliminary PR taking care of one bug, could we have more context about the issue at hand if this one doesn't handle that issue? |
versions of the product: all
affects: bucketfile and bucketclient backend
We should be able to list with both a 'prefix' and a 'marker' while having a delimiter.
Get now, _getStartIndex() masks the prefix if you have a marker.
E.g.
gives for file names
As we see some CommonPrefixes are listed as files.
The bug is located here: https://github.com/scality/Arsenal/blob/master/lib/algos/list/delimiter.js
It seems there are other inconsistencies in the code.
Please provide consistent functional (for bucketfile) and end-to-end (for metadata) test scenarios.
The text was updated successfully, but these errors were encountered: