Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPAT: return AccessDenied if Date before epochTime (01/01/1970) #198

Closed
nicolas2bert opened this issue Dec 1, 2016 · 4 comments
Closed

COMPAT: return AccessDenied if Date before epochTime (01/01/1970) #198

nicolas2bert opened this issue Dec 1, 2016 · 4 comments

Comments

@nicolas2bert
Copy link
Contributor

On ceph/s3-tests, these changes fix:

FAIL: s3tests.functional.test_headers.test_object_create_bad_date_before_epoch_aws2
FAIL: s3tests.functional.test_headers.test_bucket_create_bad_date_before_epoch_aws2
nicolas2bert added a commit that referenced this issue Dec 1, 2016
@nicolas2bert
COMPAT: Date before epoch
5f39ea9 
FIXES #198
@nicolas2bert nicolas2bert mentioned this issue Dec 1, 2016
Merged
@ghost
Copy link

ghost commented Dec 2, 2016

Does this mean a negative timestamp ? :D (just.. wat :D)

@nicolas2bert
Copy link
Contributor Author

Yes ! :)

@nicolas2bert
Copy link
Contributor Author

Should I instead of declaring const epochTime = new Date('1970-01-01').getTime();
checking for timestamp < 0 ?
I thought declaring const epochTime = new Date('1970-01-01').getTime(); made it clearer.

@ghost
Copy link

ghost commented Dec 2, 2016

Well, I think it's fine this way. Just wanted to confirm my understanding of the issue.

nicolas2bert added a commit that referenced this issue Dec 3, 2016
@nicolas2bert
COMPAT: Date before epoch
512bb9e 
FIXES #198
nicolas2bert added a commit that referenced this issue Dec 5, 2016
@nicolas2bert
COMPAT: Date before epoch
52a5dd2 
FIXES #198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolas2bert