Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors: harmonize caps #54

Closed
jmunoznaranjo opened this issue Mar 10, 2016 · 2 comments
Closed

Errors: harmonize caps #54

jmunoznaranjo opened this issue Mar 10, 2016 · 2 comments
Labels
enhancement

Comments

@jmunoznaranjo
Copy link
Contributor

Not all error codes within https://github.com/scality/IronMan-Arsenal/blob/rel/1.0/errors/arsenalErrors.json start with a capital letter. Examples: secretKeyDoesNotExist, badId...

This is error prone as proven by https://github.com/scality/IronMan-Vault/pull/228
@jmunoznaranjo
Copy link
Contributor Author

Marking this as enhancement due to the lack of 'refactor-wanted'.

koolfunky pushed a commit that referenced this issue Mar 14, 2016
(errors) harmonize caps
1a1d091 
 * Make all errors start with capital letter
 * fix #54
koolfunky pushed a commit that referenced this issue Mar 14, 2016
(errors) harmonize caps
2bf25bb 
 * Make all errors start with capital letter
 * fix #54
@koolfunky koolfunky mentioned this issue Mar 16, 2016
Merged
koolfunky pushed a commit that referenced this issue Mar 16, 2016
(errors) harmonize caps
8fbbc36 
 * Make all errors start with capital letter
 * fix #54
koolfunky pushed a commit that referenced this issue Mar 16, 2016
(errors) harmonize caps
45c9d5b 
 * Make all errors start with capital letter
 * fix #54
@koolfunky
Copy link

solved with #64

jmunoznaranjo pushed a commit that referenced this issue Mar 22, 2016
@jmunoznaranjo
(errors) harmonize caps
95db6c8 
 * Make all errors start with capital letter
 * fix #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koolfunky @jmunoznaranjo