-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rf: ZENKO-285 Single test for range calculation #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the earlier setup the right way of writing tests? With this approach, you are testing multiple cases in one test. This would go against our a test should test only one thing
approach.
I was viewing this unit as a test of the range calculation (while across multiple inputs, it's testing the same calculation). The primary motivation, though, is to improve the test suite usability—i.e. encapsulating the output of ~9000 test statements into a single one. |
In this particular case I think it's fine because it's essentially testing one thing (with 10000 different inputs though), but having 10000 separate tests is overkill and clutters the output making it hard to get the result from other tests, so I suggested this change to Bennett. |
I've also observed the complete unit tests run to take more than 30 seconds to complete and show a status after the last test has been executed, I'm strongly suspecting this change will significantly reduce this time. |
d331e79
to
342d37b
Compare
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
PR has been updated. Reviewers, please be cautious. |
No description provided.