bf: ZENKO-408 no zookeeper provisioning for conductor #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmacro
previously approved these changes
May 24, 2018
philipyoo
previously approved these changes
May 24, 2018
ironman-machine
dismissed stale reviews from tmacro and philipyoo
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
jonathan-gramain
force-pushed
the
bf/ZENKO-408-noZookeeperProvisioningForLifecycleConductor
branch
from
9018cfe
to
bda281f
Compare
ironman-machine
dismissed stale reviews from philipyoo and tmacro
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
philipyoo
previously approved these changes
May 29, 2018
| @@ -63,7 +61,6 @@ class LifecycleConductor { | |||
| this._zkClient = null; | |||
| this._started = false; | |||
| this._isActive = false; | |||
There was a problem hiding this comment.
can also remove this variable i think
There was a problem hiding this comment.
thanks, just removed
Disable zookeeper provisioning for lifecycle conductors, unless the option useZookeeperDispatcher is set to true. This will only be set for 7.4.x.
jonathan-gramain
force-pushed
the
bf/ZENKO-408-noZookeeperProvisioningForLifecycleConductor
branch
from
bda281f
to
060e18f
Compare
ironman-machine
dismissed
philipyoo’s stale review
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
philipyoo
approved these changes
May 29, 2018
jonathan-gramain
deleted the
bf/ZENKO-408-noZookeeperProvisioningForLifecycleConductor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable zookeeper provisioning for lifecycle conductors, as kubernetes is able to spawn the required number of instances (i.e. 1) and respawn on another machine whenever one goes down. The zookeeper provisioning was used for about the same purpose.