Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PTFE-600] Crash on boot #128

Merged
merged 4 commits into from
Jul 19, 2023
Merged

[PTFE-600] Crash on boot #128

merged 4 commits into from
Jul 19, 2023

Conversation

gaspardmoindrot
Copy link
Contributor

No description provided.

@gaspardmoindrot gaspardmoindrot requested a review from a team as a code owner July 18, 2023 21:36
@gaspardmoindrot gaspardmoindrot self-assigned this Jul 18, 2023
@bert-e
Copy link
Contributor

bert-e commented Jul 18, 2023

Hello gaspardmoindrot,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@gaspardmoindrot gaspardmoindrot removed their assignment Jul 19, 2023
tcarmet
tcarmet approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are an improvement as is, we'll take it and iterate if needed.

manifests/base/secrets.env Show resolved Hide resolved
@tcarmet tcarmet merged commit 6feec22 into development/3.8 Jul 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmet tcarmet tcarmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaspardmoindrot @bert-e @tcarmet