Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BERTE-576 documenting the queue for users #65

Merged
merged 3 commits into from
Aug 30, 2022
Merged

BERTE-576 documenting the queue for users #65

merged 3 commits into from
Aug 30, 2022

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Aug 29, 2022

No description provided.

@tcarmet tcarmet requested a review from a team as a code owner August 29, 2022 11:24
@bert-e
Copy link
Contributor

bert-e commented Aug 29, 2022

Hello tcarmet,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 29, 2022

Incorrect fix version

The Fix Version/s in issue BERTE-576 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 3.6.23

Please check the Fix Version/s of BERTE-576, or the target
branch of this pull request.

@tcarmet tcarmet force-pushed the feature/BERTE-576-document-queue branch from bd4d0e3 to ac82c84 Compare August 29, 2022 11:32
nootal
nootal requested changes Aug 29, 2022
View reviewed changes
bert_e/docs/USER_DOC.md Outdated Show resolved Hide resolved
bert_e/docs/USER_DOC.md Outdated Show resolved Hide resolved
bert_e/docs/USER_DOC.md Outdated Show resolved Hide resolved
bert_e/docs/USER_DOC.md Outdated Show resolved Hide resolved
bert_e/docs/USER_DOC.md Show resolved Hide resolved
bert_e/docs/USER_DOC.md Show resolved Hide resolved
bert_e/docs/USER_DOC.md Outdated Show resolved Hide resolved
tcarmet and others added 2 commits August 30, 2022 14:19
@tcarmet @nootal
Apply suggestions from code review
f346ad3 
Co-authored-by: Charles Prost - Scality <7427667+nootal@users.noreply.github.com>
@tcarmet
review on queue
289bbe1
@tcarmet tcarmet force-pushed the feature/BERTE-576-document-queue branch from 3d44298 to 289bbe1 Compare August 30, 2022 12:32
@tcarmet tcarmet requested a review from nootal August 30, 2022 12:33
@tcarmet
Copy link
Contributor Author

tcarmet commented Aug 30, 2022

/approve

@bert-e
Copy link
Contributor

bert-e commented Aug 30, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@tcarmet tcarmet merged commit e5db393 into development/3.6 Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nootal nootal nootal approved these changes

@robin-hesling robin-hesling Awaiting requested review from robin-hesling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tcarmet @bert-e @nootal