Merge pull request #1021 from scality/bugfix/962-versionlock-pkgs-1.1

Versionlocks docker & node_exporter packages - development/1.1

ChangeLog.rst

@@ -50,6 +50,10 @@ the index provisioning job (:ghpull:`233`).
 Release 1.0.2 (in development)
 ==============================
 
+Bugs fixed
+----------
+:ghissue:`962` - Versionlocks `docker` & `node_exporter` packages
+
 
 Release 1.0.1
 =============

playbooks/deploy.yml

@@ -1,3 +1,5 @@
+---
+
 - import_playbook: 'init.yml'
   tags: ['init']
 
@@ -10,6 +12,9 @@
 - import_playbook: '../vendor/kubespray/cluster.yml'
   tags: kubespray
 
+- import_playbook: 'kubespray-post.yml'
+  tags: ['kubespray']
+
 - import_playbook: 'storage-post.yml'
   tags: ['storage']
 

playbooks/kubespray-post.yml

@@ -0,0 +1,10 @@
+---
+
+- hosts: k8s-cluster
+  gather_facts: False
+  tags:
+    - kubespray
+  tasks:
+    - include_role:
+        name: docker
+        tasks_from: version_lock

playbooks/kubespray-pre.yml

@@ -1,3 +1,5 @@
+---
+
 - hosts: k8s-cluster
   any_errors_fatal: '{{ any_errors_fatal | default(true) }}'
   gather_facts: False
@@ -6,3 +8,7 @@
   roles:
     - role: ../vendor/kubespray/roles/kubespray-defaults/
     - role: kubespray_var_patcher
+  tasks:
+    - include_role:
+        name: docker
+        tasks_from: version_unlock

playbooks/scale.yml

@@ -1,3 +1,5 @@
+---
+
 - import_playbook: 'init.yml'
   tags: ['init']
 
@@ -10,5 +12,8 @@
 - import_playbook: '../vendor/kubespray/scale.yml'
   tags: ['kubespray']
 
+- import_playbook: 'kubespray-post.yml'
+  tags: ['kubespray']
+
 - import_playbook: 'storage-post.yml'
   tags: ['storage']

roles/docker/defaults/main.yml

@@ -0,0 +1,7 @@
+---
+
+docker_yum_versionlock_file: /etc/yum/pluginconf.d/versionlock.list
+
+docker_package_names:
+  - docker-ce
+  - docker-engine

roles/docker/tasks/version_lock.yml

@@ -0,0 +1,25 @@
+---
+
+- name: install yum-plugin-versionlock
+  yum:
+    name: yum-plugin-versionlock
+    state: present
+
+- name: retrieve installed docker package
+  command: rpm -qa "{{ item }}" --qf "0:%{NAME}-%{VERSION}-%{RELEASE}.*"
+  args:
+    warn: no
+  changed_when: no
+  register: installed_docker_package
+  with_items: '{{ docker_package_names }}'
+
+- name: lock docker package version
+  vars:
+    versionlock_rule: '{{
+      installed_docker_package.results |
+      selectattr("stdout") |
+      map(attribute="stdout") |
+      first }}'
+  lineinfile:
+    dest: '{{ docker_yum_versionlock_file }}'
+    line: '{{ versionlock_rule }}'

roles/docker/tasks/version_unlock.yml

@@ -0,0 +1,8 @@
+---
+
+- name: unlock docker package version
+  lineinfile:
+    state: absent
+    dest: '{{ docker_yum_versionlock_file }}'
+    regexp: '0:{{ item }}-.*'
+  with_items: '{{ docker_package_names }}'

roles/node_exporter/tasks/main.yml

@@ -34,16 +34,21 @@
     name: yum-plugin-versionlock
     state: present
 
-- name: 'lock version of node_exporter'
-  lineinfile:
-    dest: /etc/yum/pluginconf.d/versionlock.list
-    line: 0:node_exporter-{{ node_exporter_version }}
-    regexp: '0:node_exporter-.*'
+# Unlock before, in case the version of node_exporter has changed,
+# otherwise it will prevent the installation of the package,
+# even if the versionlock rule is replaced by the new version.
+- name: 'unlock version of node_exporter'
+  shell: yum versionlock delete node_exporter-*
+  failed_when: no
 
 - name: 'install Prometheus Node exporter'
   yum:
     name: node_exporter-{{ node_exporter_version }}
     state: present
+    allow_downgrade: yes
+
+- name: 'lock version of node_exporter'
+  command: yum versionlock add node_exporter-{{ node_exporter_version }}
 
 - name: 'Start and enable the node_exporter service'
   service: