Skip to content

Commit

Permalink
tox: pin basepython to python3.6 in lint-python
Browse files Browse the repository at this point in the history
A future commit updates the version of `pylint` we use to validate
Python code, which does not work properly with Python 3.9 at the time of
writing, which is the default Python on e.g., a Fedora 32 system.

Instead, pin the Python version to the (Python 3) version as found on
our target system(s), i.e., RHEL/CentOS 7, so Python 3.6.

See: pylint-dev/pylint#3882
See: https://scality.slack.com/archives/CFXQQUDPT/p1608201195013900?thread_ts=1608200122.011200&cid=CFXQQUDPT
  • Loading branch information
NicolasT committed Dec 17, 2020
1 parent 2209929 commit 504151d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions eve/workers/pod-linter/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ RUN dnf install -y git \
python-pip \
python3 \
python3-devel \
python36 \
ShellCheck \
&& dnf clean all \
&& adduser -u 1042 --home /home/eve eve \
Expand Down
2 changes: 2 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ commands =
[testenv:lint-python]
description =
Lint Python files using pylint and mypy.
# Set Python version to Python3 as shipped with RHEL/CentOS 7
basepython = python3.6
deps =
-r{toxinidir}/buildchain/requirements-{env:OSTYPE}.txt
-r{toxinidir}/buildchain/requirements-dev.txt
Expand Down

0 comments on commit 504151d

Please sign in to comment.