Skip to content

Commit

Permalink
operator,storage-operator: Pin setup-envtest version
Browse files Browse the repository at this point in the history
Since few days setup-envtest does no longer works with Go prior to 1.19,
so let's use a specific git commit hash to install setup-envtest (since
there is no tags on this module)

Sees: kubernetes-sigs/controller-runtime#2537
  • Loading branch information
TeddyAndrieux authored and eg-ayoub committed Oct 11, 2023
1 parent dadd559 commit b710792
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion operator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ $(CONTROLLER_GEN): $(LOCALBIN)
.PHONY: envtest
envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
$(ENVTEST): $(LOCALBIN)
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@7db81c7

.PHONY: bundle
bundle: manifests kustomize ## Generate bundle manifests and metadata, then validate generated files.
Expand Down
2 changes: 1 addition & 1 deletion storage-operator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ kustomize: ## Download kustomize locally if necessary.

ENVTEST = $(shell pwd)/bin/setup-envtest
envtest: ## Download envtest-setup locally if necessary.
$(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)
$(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@7db81c7)

# go-get-tool will 'go get' any package $2 and install it to $1.
PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
Expand Down

0 comments on commit b710792

Please sign in to comment.