build,script,salt: Pin salt version in bootstrap and restore

In bootstrap and restore we install salt-minion on the node so we need
to pin the salt version we want to install and not just install the one
yum will find depending on various things (like available versions,
priority on repos, ...).
Also set the priority to 1 on all our repos so that our repositories has
priority over others if the `yum-plugin-priorities` package is
installed.
NOTE: If `yum-plugin-priorities` is installed and priority is set on one
repos then other repos with the same package will just be ignored
(e.g.: epel installed with priority=98 we cannot install `salt-3000.3`
as salt-3000.3 is excluded because a repo with some priority has the
package in a different version)

Fixes: #2704

buildchain/buildchain/iso.py

@@ -85,7 +85,10 @@
                 task_name='bootstrap.sh',
                 source=constants.ROOT/'scripts'/'bootstrap.sh.in',
                 destination=constants.ISO_ROOT/'bootstrap.sh',
-                context={'VERSION': versions.VERSION},
+                context={
+                    'VERSION': versions.VERSION,
+                    'SALT_VERSION': versions.SALT_VERSION
+                },
                 file_dep=[versions.VERSION_FILE],
                 task_dep=['_iso_mkdir_root'],
             ),
@@ -101,7 +104,10 @@
                 task_name='restore.sh',
                 source=constants.ROOT/'scripts'/'restore.sh.in',
                 destination=constants.ISO_ROOT/'restore.sh',
-                context={'VERSION': versions.VERSION},
+                context={
+                    'VERSION': versions.VERSION,
+                    'SALT_VERSION': versions.SALT_VERSION
+                },
                 file_dep=[versions.VERSION_FILE],
                 task_dep=['_iso_mkdir_root'],
             ),

salt/metalk8s/repo/redhat.sls

@@ -65,6 +65,9 @@ Configure {{ repo_name }} repository:
   {%- endif %}
     - repo_gpg_check: {{ repo_config.repo_gpg_check }}
     - enabled: {{ repo_config.enabled }}
+    # Set priority to 1, even if the `yum-plugin-priorities` is not installed,
+    # so that our repos has priority over others
+    - priority: 1
     # URL to the proxy server for this repository.
     # Set to '_none_' to disable the global proxy setting
     # for this repository.

scripts/bootstrap.sh.in

@@ -56,7 +56,7 @@ BASE_DIR=$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")
 SALT_CALL=${SALT_CALL:-salt-call}
 
 declare -a PACKAGES=(
-    salt-minion
+    salt-minion-@@SALT_VERSION
     genisoimage
 )
 

scripts/common.sh

@@ -95,6 +95,7 @@ configure_yum_local_repository() {
 name=$repo_name
 baseurl=file://$repo_path
 enabled=1
+priority=1
 gpgcheck=$gpgcheck
 ${gpg_keys:+gpgkey=${gpg_keys%?}}
 EOF

scripts/restore.sh.in

@@ -70,7 +70,7 @@ BASE_DIR=$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")
 SALT_CALL=${SALT_CALL:-salt-call}
 
 declare -a PACKAGES=(
-    salt-minion
+    salt-minion-@@SALT_VERSION
     genisoimage
 )