Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage Operator ClusterRole has too much permissions #2084

Closed
gdemonet opened this issue Nov 27, 2019 · 0 comments
Closed

Storage Operator ClusterRole has too much permissions #2084

gdemonet opened this issue Nov 27, 2019 · 0 comments
Assignees
@gdemonet
Labels
kind:debt Technical debt topic:storage Issues related to storage
Projects
Week 25/2020 Week 26/2020

Comments

@gdemonet
Copy link
Contributor

Component: storage-operator

Why this is needed: We don't want to setup permissions for components that don't need them specifically, as a good practice (wouldn't want a bug in there that creates turmoil in the cluster for no good reason).

What should be done: Remove all unneeded permissions from the ClusterRole defined in storage-operator/deploy/role.yaml.
@gdemonet gdemonet added topic:storage Issues related to storage moonshot kind:debt Technical debt labels Nov 27, 2019
@gdemonet gdemonet mentioned this issue Nov 27, 2019
Merged
@slaperche-scality slaperche-scality mentioned this issue Feb 25, 2020
Closed
@slaperche-scality slaperche-scality mentioned this issue Jun 18, 2020
Closed
@gdemonet gdemonet self-assigned this Jun 18, 2020
gdemonet added a commit that referenced this issue Jun 18, 2020
@gdemonet
storage-operator: Tighten ClusterRole permissions
3810e4e 
We don't want too open permissions for security reasons that were made
obvious in #2634. We thus reduce the rules deployed to the bare minimum,
and add some inline comments to better explain why each ruleset is
needed.

Fixes: #2084
@gdemonet gdemonet added this to In progress in Week 25/2020 Jun 18, 2020
@gdemonet gdemonet mentioned this issue Jun 18, 2020
Merged
@gdemonet gdemonet added this to In progress in Week 26/2020 Jun 23, 2020
@gdemonet gdemonet moved this from In progress to Reviewer approved in Week 26/2020 Jun 23, 2020
@bert-e bert-e closed this as completed in 7bea636 Jun 23, 2020
Week 25/2020 automation moved this from In progress to Done Jun 23, 2020
Week 26/2020 automation moved this from Reviewer approved to Done Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdemonet gdemonet

Labels
kind:debt Technical debt topic:storage Issues related to storage
Projects
No open projects
Week 25/2020
  
Done
Week 26/2020
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdemonet