Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt upgrade do not work properly #2524

Closed
TeddyAndrieux opened this issue May 5, 2020 · 0 comments
Closed

Salt upgrade do not work properly #2524

TeddyAndrieux opened this issue May 5, 2020 · 0 comments
Assignees
Labels
complexity:medium Something that requires one or few days to fix kind:bug Something isn't working release:blocker An issue that blocks a release until resolved topic:lifecycle Issues related to upgrade or downgrade of MetalK8s

Comments

@TeddyAndrieux
Copy link
Collaborator

TeddyAndrieux commented May 5, 2020

Component:

'salt'

What happened:

Currently salt upgrade (and downgrade) does not work properly as salt-minion is not restarted properly when upgrading and orchestrate fail with <minion_name>: False as minion take too much time to answer because of upgrade + restart.

What was expected:

Working orchestrate upgrade

Steps to reproduce

Try to upgrade with a Salt version change

Resolution proposal (optional):

Restart minion properly after an upgrade

@TeddyAndrieux TeddyAndrieux added kind:bug Something isn't working topic:lifecycle Issues related to upgrade or downgrade of MetalK8s complexity:medium Something that requires one or few days to fix release:blocker An issue that blocks a release until resolved labels May 5, 2020
@TeddyAndrieux TeddyAndrieux self-assigned this May 5, 2020
@TeddyAndrieux TeddyAndrieux added this to To do in Week 19/2020 via automation May 5, 2020
@TeddyAndrieux TeddyAndrieux moved this from To do to In progress in Week 19/2020 May 5, 2020
TeddyAndrieux added a commit that referenced this issue May 5, 2020
Install salt-minion salt state may also upgrade and downgrade
salt-minion package, and this salt version change may have impact on
the running salt states, so make this salt states running at the end of
the state.

Refs: #2524
TeddyAndrieux added a commit that referenced this issue May 5, 2020
In `deploy_node` orchestrate during `Reconfigure salt-minion` salt state
we may upgrade, downgrade salt-minion package and restart salt-minion
service so salt-minion may miss some of the salt-master job query,
increase timeout so that minion have time to upgrade, downgrade and
restart if needed

Fixes: #2524
TeddyAndrieux added a commit that referenced this issue May 5, 2020
Install salt-minion salt state may also upgrade and downgrade
salt-minion package, and this salt version change may have impact on
the running salt states, so make this salt states running at the end of
the state.

Refs: #2524
TeddyAndrieux added a commit that referenced this issue May 5, 2020
In `deploy_node` orchestrate during `Reconfigure salt-minion` salt state
we may upgrade, downgrade salt-minion package and restart salt-minion
service so salt-minion may miss some of the salt-master job query,
increase timeout so that minion have time to upgrade, downgrade and
restart if needed

Fixes: #2524
TeddyAndrieux added a commit that referenced this issue May 6, 2020
Install salt-minion salt state may also upgrade and downgrade
salt-minion package, and this salt version change may have impact on
the running salt states, so make this salt states running at the end of
the state.

Refs: #2524
@bert-e bert-e closed this as completed in 282e0d9 May 6, 2020
Week 19/2020 automation moved this from In progress to Done May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:medium Something that requires one or few days to fix kind:bug Something isn't working release:blocker An issue that blocks a release until resolved topic:lifecycle Issues related to upgrade or downgrade of MetalK8s
Projects
No open projects
Week 19/2020
  
Done
Development

No branches or pull requests

1 participant