Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install (rightfully) fails when Docker is installed, but this is hard to troubleshoot #2992

Closed
NicolasT opened this issue Dec 18, 2020 · 0 comments · Fixed by #3050
Closed

Install (rightfully) fails when Docker is installed, but this is hard to troubleshoot #2992

NicolasT opened this issue Dec 18, 2020 · 0 comments · Fixed by #3050
Assignees
@TeddyAndrieux
Labels
complexity:medium Something that requires one or few days to fix good first issue Good for newcomers kind:enhancement New feature or request topic:deployment Bugs in or enhancements to deployment stages

Comments

@NicolasT
Copy link
Contributor

NicolasT commented Dec 18, 2020 •
edited

When docker is installed on a host, the installation fails (and should fail). docker has a Provides for runc which we want to install, but it's not a 'good' version of runc (and containerd). At some later point in time, install will then fail for obscure reasons.

#2960 could help to make the late error a bit more clear, but it's still difficult to link this (as a user) to docker being installed on the system.

As such, it likely makes sense to keep some kind of blacklist of 'known incompatible' packages, and ensuring these are not installed, either in a Salt state (somehow?), or in bootstrap.sh (though then the same checks would not be performed on non-bootstrap nodes...)

Known conflicting packages:

Also suggested by @Baitanik in #2989 (comment) and reported earlier by @vrancurel.
@NicolasT NicolasT added kind:enhancement New feature or request good first issue Good for newcomers topic:deployment Bugs in or enhancements to deployment stages complexity:medium Something that requires one or few days to fix labels Dec 18, 2020
@TeddyAndrieux TeddyAndrieux self-assigned this Jan 14, 2021
TeddyAndrieux added a commit that referenced this issue Jan 18, 2021
@TeddyAndrieux
salt: Add a check about conflicting packages for MetalK8s
3f559cb 
If some package are installed on the host where we want to deploy
MetalK8s the installation does not work (e.g: containerd.io)
Add a new function to check that those package are not installed on the
host before deploying all the MetalK8s components.
NOTE: We do not automatically uninstall the package from the host since
those packages may have been installed for good reason, so just ask the
user to remove those packages

Fixes: #2992
@TeddyAndrieux TeddyAndrieux mentioned this issue Jan 18, 2021
Merged
TeddyAndrieux added a commit that referenced this issue Jan 18, 2021
@TeddyAndrieux
salt: Add a check about conflicting packages for MetalK8s
ab3c60a 
If some package are installed on the host where we want to deploy
MetalK8s the installation does not work (e.g: containerd.io)
Add a new function to check that those package are not installed on the
host before deploying all the MetalK8s components.
NOTE: We do not automatically uninstall the package from the host since
those packages may have been installed for good reason, so just ask the
user to remove those packages

Fixes: #2992
@bert-e bert-e closed this as completed in 49dcaa4 Jan 19, 2021
gdemonet pushed a commit that referenced this issue Feb 26, 2021
@TeddyAndrieux @gdemonet
salt: Add a check about conflicting packages for MetalK8s
621707b 
If some package are installed on the host where we want to deploy
MetalK8s the installation does not work (e.g: containerd.io)
Add a new function to check that those package are not installed on the
host before deploying all the MetalK8s components.
NOTE: We do not automatically uninstall the package from the host since
those packages may have been installed for good reason, so just ask the
user to remove those packages

Fixes: #2992
Cherry-picked from: 49dcaa4
gdemonet pushed a commit that referenced this issue Feb 26, 2021
@TeddyAndrieux @gdemonet
salt: Add a check about conflicting packages for MetalK8s
a1a178d 
If some package are installed on the host where we want to deploy
MetalK8s the installation does not work (e.g: containerd.io)
Add a new function to check that those package are not installed on the
host before deploying all the MetalK8s components.
NOTE: We do not automatically uninstall the package from the host since
those packages may have been installed for good reason, so just ask the
user to remove those packages

Fixes: #2992
Cherry-picked from: 49dcaa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeddyAndrieux TeddyAndrieux

Labels
complexity:medium Something that requires one or few days to fix good first issue Good for newcomers kind:enhancement New feature or request topic:deployment Bugs in or enhancements to deployment stages
Projects
None yet
Milestone
No milestone
2 participants
@NicolasT @TeddyAndrieux