Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor all system volumes with node_exporter #31

Closed
NicolasT opened this issue Mar 26, 2018 · 3 comments
Closed

Monitor all system volumes with node_exporter #31

NicolasT opened this issue Mar 26, 2018 · 3 comments
Assignees
@Zempashi @ballot-scality
Labels
kind:bug Something isn't working kind:design Solution design choices state:help wanted Extra attention is needed state:question Further information is requested topic:operations Operations-related issues topic:storage Issues related to storage
Projects
Host & cluster monitoring
Milestone
MetalK8s 1.0.0

Comments

@NicolasT
Copy link
Contributor

Currently node_exporter doesn't monitor all volumes available on the system: as https://github.com/prometheus/node_exporter/blob/1f11a86d594173ca1146ac1d1715cd6263e9959d/README.md#using-docker mentions, we'd need to bind all volumes in a node_exporter VM, which is impractical, most certainly because we're not setting up the node_exporter DaemonSet ourself...

It may be possible to work around this using MountPropagation and some other settings (but then see prometheus/node_exporter#672 and prometheus/node_exporter#660), which is far from ideal.

Maybe the best way forward would be to simply deploy node_exporter on all nodes, as it's intended to be deployed, and not let kube-prometheus (or prometheus-operator) manage it, just make sure the metrics are collected as intended.
@NicolasT NicolasT added kind:bug Something isn't working state:help wanted Extra attention is needed state:question Further information is requested kind:design Solution design choices topic:storage Issues related to storage topic:operations Operations-related issues labels Mar 26, 2018
@ballot-scality
Copy link

We might rely on https://copr.fedorainfracloud.org/coprs/ibotty/prometheus-exporters/
As stated in the node exporter README it is a 3rdparty maintained closely with upstream.

@NicolasT
Copy link
Contributor Author

Cool. Would you want to work on this? We may need to figure out how to let kube-prometheus then use the host-installed exporter and such...

@NicolasT
Copy link
Contributor Author

prometheus-operator/prometheus-operator#569 (comment)

ballot-scality added a commit that referenced this issue May 2, 2018
@ballot-scality
Issue #31: Set DeployExporter to False by default in kube_prometheus
dfa4407 
helm charts
@NicolasT NicolasT mentioned this issue May 18, 2018
Closed
Zempashi pushed a commit that referenced this issue Jun 28, 2018
@ballot-scality
Issue #31: Set DeployExporter to False by default in kube_prometheus
8d069f3 
helm charts
@thomasdanan thomasdanan moved this from To do to In progress in Host & cluster monitoring Jun 29, 2018
@NicolasT NicolasT added this to the MetalK8s 1.0.0 milestone Jul 4, 2018
@Zempashi Zempashi mentioned this issue Jul 4, 2018
Merged
Host & cluster monitoring automation moved this from In progress to Done Jul 5, 2018
NicolasT added a commit that referenced this issue Jul 9, 2018
@NicolasT
node_exporter: Enable repository GPG keys
23f17d9 
See: c73b5f3
See: ansible/ansible#20711
See: #113
See: #113
See: #31
See: #31
NicolasT added a commit that referenced this issue Jul 9, 2018
@NicolasT
kube_prometheus: Use upstream 'external node_exporter' feature
3afabd1 
Fixes: https://github.com/scality/metal-k8s/projects/1#card-11097887
See: #31
See: #31
See: #113
See: #113
See: prometheus-operator/prometheus-operator#1560
@NicolasT NicolasT mentioned this issue Jul 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zempashi Zempashi

@ballot-scality ballot-scality

Labels
kind:bug Something isn't working kind:design Solution design choices state:help wanted Extra attention is needed state:question Further information is requested topic:operations Operations-related issues topic:storage Issues related to storage
Projects
No open projects
Host & cluster monitoring
  
Done
Milestone
MetalK8s 1.0.0
Development

No branches or pull requests
3 participants
@NicolasT @Zempashi @ballot-scality