Format LVM volumes asynchronously #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zempashi
force-pushed
the
asynchronous_lv_formating
branch
from
1468272
to
c43045b
Compare
NicolasT
reviewed
Jul 23, 2018
ChangeLog.rst
Outdated
| @@ -13,6 +13,10 @@ upgrading a MetalK8s 0.1 cluster to MetalK8s 0.2 (:ghissue:`147`) | |||
| storage related actions. Please see :ref:`upgrade_from_MetalK8s_before_0.2.0` | |||
| (:ghissue:`153`) | |||
|
|
|||
| Bugs fixed | |||
There was a problem hiding this comment.
I wondered a long time about this... So it's a feature added with a ghissue ?
There was a problem hiding this comment.
There are only 'Issues' on Github (and 'Notes' in a 'Project'), so yeah. It's a bit of a misnomer, but we've been using 'Issues' to track features for quite a while already...
NicolasT
changed the title
|
Can this be retargetted to |
Zempashi
force-pushed
the
asynchronous_lv_formating
branch
from
c43045b
to
f5ee3e9
Compare
NicolasT
suggested changes
Jul 25, 2018
ChangeLog.rst
Outdated
| @@ -38,6 +38,10 @@ upgrading a MetalK8s 0.1 cluster to MetalK8s 0.2 (:ghissue:`147`) | |||
| storage related actions. Please see :ref:`upgrade_from_MetalK8s_before_0.2.0` | |||
| (:ghissue:`153`) | |||
|
|
|||
| Features added | |||
There was a problem hiding this comment.
This should go in the 1.0.0 section
ChangeLog.rst
Outdated
| @@ -38,6 +38,10 @@ upgrading a MetalK8s 0.1 cluster to MetalK8s 0.2 (:ghissue:`147`) | |||
| storage related actions. Please see :ref:`upgrade_from_MetalK8s_before_0.2.0` | |||
| (:ghissue:`153`) | |||
|
|
|||
| Features added | |||
| -------------- | |||
| :ghissue:`173` - Format pv in asynchronous mode (:ghpull:`181`) | |||
There was a problem hiding this comment.
:ghpull:`181` - format `PersistentVolumes` asynchronously (:ghissue:`173`)
f5ee3e9
to
e083cb9
Compare
Zempashi
force-pushed
the
asynchronous_lv_formating
branch
from
e083cb9
to
fcf8844
Compare
NicolasT
previously approved these changes
Jul 26, 2018
NicolasT
approved these changes
Jul 26, 2018
NicolasT
added
kind:enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #173